From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbcFUIeb (ORCPT ); Tue, 21 Jun 2016 04:34:31 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:17118 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752572AbcFUIeZ (ORCPT ); Tue, 21 Jun 2016 04:34:25 -0400 X-IBM-Helo: d28dlp03.in.ibm.com X-IBM-MailFrom: srikar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 21 Jun 2016 13:57:14 +0530 From: Srikar Dronamraju To: Josh Poimboeuf Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Mel Gorman , Matt Fleming Subject: Re: [PATCH 0/5] sched/debug: decouple sched_stat tracepoints from CONFIG_SCHEDSTATS Reply-To: Srikar Dronamraju References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062108-0004-0000-0000-000002AA0293 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062108-0005-0000-0000-00000D8F4D9B Message-Id: <20160621082714.GA17323@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-21_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606210102 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf [2016-06-17 12:43:22]: > NOTE: I didn't include any performance numbers because I wasn't able to > get consistent results. I tried the following on a Xeon E5-2420 v2 CPU: > > $ for i in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do echo -n performance > $i; done > $ echo 1 > /sys/devices/system/cpu/intel_pstate/no_turbo > $ echo 100 > /sys/devices/system/cpu/intel_pstate/min_perf_pct > $ echo 0 > /proc/sys/kernel/nmi_watchdog > $ taskset 0x10 perf stat -n -r10 perf bench sched pipe -l 1000000 > > I was going to post the numbers from that, both with and without > SCHEDSTATS, but then when I tried to repeat the test on a different day, > the results were surprisingly different, with different conclusions. > > So any advice on measuring scheduler performance would be appreciated... > > Josh Poimboeuf (5): > sched/debug: rename and move enqueue_sleeper() > sched/debug: schedstat macro cleanup > sched/debug: 'schedstat_val()' -> 'schedstat_val_or_zero()' > sched/debug: remove several CONFIG_SCHEDSTATS guards > sched/debug: decouple 'sched_stat_*' tracepoints' from > CONFIG_SCHEDSTATS > This patchset looks good to me. Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju