From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH 0/2] Check MAC address length when changing it
Date: Tue, 21 Jun 2016 08:52:47 -0700 [thread overview]
Message-ID: <20160621085247.39fc11ba@xeon-e3> (raw)
In-Reply-To: <1466086780-5613-1-git-send-email-phil@nwl.cc>
On Thu, 16 Jun 2016 16:19:38 +0200
Phil Sutter <phil@nwl.cc> wrote:
> Due to minimal checking in kernel space, MAC address setting was
> problematic in multiple ways:
>
> - Setting an overly long MAC address was accepted and the extra parts
> simply ignored.
>
> - Setting an overly short MAC address for VFs was accepted and the
> missing part filled with random garbage.
>
> While patch 1 makes sure that in the second case above missing parts are
> padded with zero, patch 2 implements a real solution for both by
> comparing new and old address lengths prior to accepting the input. For
> VFs it is simply assumed that the length must match that of the PF's
> address.
>
> Phil Sutter (2):
> iplink: Add missing variable initialization
> iplink: Check address length via netlink
>
> ip/iplink.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 51 insertions(+), 3 deletions(-)
>
Sure. Applied
prev parent reply other threads:[~2016-06-21 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 14:19 [iproute PATCH 0/2] Check MAC address length when changing it Phil Sutter
2016-06-16 14:19 ` [iproute PATCH 1/2] iplink: Add missing variable initialization Phil Sutter
2016-06-16 14:19 ` [iproute PATCH 2/2] iplink: Check address length via netlink Phil Sutter
2016-06-21 15:52 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621085247.39fc11ba@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.