From: Christoph Hellwig <hch@lst.de>
To: Shaun Tancheff <shaun@tancheff.com>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Tejun Heo <tj@kernel.org>, Christoph Hellwig <hch@lst.de>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: [PATCH v3] Add support for SCT Write Same
Date: Tue, 21 Jun 2016 14:41:44 +0200 [thread overview]
Message-ID: <20160621124144.GD1689@lst.de> (raw)
In-Reply-To: <1466435028-13886-2-git-send-email-shaun@tancheff.com>
On Mon, Jun 20, 2016 at 10:03:48AM -0500, Shaun Tancheff wrote:
> index bfec66f..3dcc29e 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1204,6 +1204,9 @@ static int ata_scsi_dev_config(struct scsi_device *sdev,
> if (!ata_id_has_unload(dev->id))
> dev->flags |= ATA_DFLAG_NO_UNLOAD;
>
> + if (ata_id_sct_write_same(dev->id))
> + sdev->sct_write_same = 1;
> +
No need scsi_device flags for libata internal data. You need to expose
your capabilities through the SCSI protocol to the SCSI midlayer.
next prev parent reply other threads:[~2016-06-21 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:03 [PATCH v3] Add support for Write Same via SCT Shaun Tancheff
2016-06-20 15:03 ` [PATCH v3] Add support for SCT Write Same Shaun Tancheff
2016-06-21 12:41 ` Christoph Hellwig [this message]
2016-06-22 2:43 ` Martin K. Petersen
2016-06-22 3:01 ` Shaun Tancheff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621124144.GD1689@lst.de \
--to=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.