From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/2] drm/omap: dsi: Remove unused variable Date: Tue, 21 Jun 2016 16:01:38 +0200 Message-ID: <20160621140138.GA21079@ulmo.ba.sec> References: <20160621135645.20301-1-thierry.reding@gmail.com> <5769486F.9010006@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1229535019==" Return-path: Received: from mail-pa0-x244.google.com (mail-pa0-x244.google.com [IPv6:2607:f8b0:400e:c03::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8554E6E10B for ; Tue, 21 Jun 2016 14:01:42 +0000 (UTC) Received: by mail-pa0-x244.google.com with SMTP id ts6so1427040pac.0 for ; Tue, 21 Jun 2016 07:01:42 -0700 (PDT) In-Reply-To: <5769486F.9010006@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Peter Ujfalusi , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1229535019== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2016 at 05:00:15PM +0300, Tomi Valkeinen wrote: > Hi Thierry, >=20 > On 21/06/16 16:56, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the > > only user of the local 'r' variable, which thus became unused. > >=20 > > Signed-off-by: Thierry Reding > > --- > > drivers/gpu/drm/omapdrm/dss/dsi.c | 1 - > > 1 file changed, 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdr= m/dss/dsi.c > > index 6f45e9d00b41..e1be5e795cd8 100644 > > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > > @@ -1167,7 +1167,6 @@ static int dsi_regulator_init(struct platform_dev= ice *dsidev) > > { > > struct dsi_data *dsi =3D dsi_get_dsidrv_data(dsidev); > > struct regulator *vdds_dsi; > > - int r; > > =20 > > if (dsi->vdds_dsi_reg !=3D NULL) > > return 0; > >=20 >=20 > Thanks, but there's already 85332739628fe4beafecdb713438c7cb1454c2f5 > ("drm/omap: fix unused variable warning in dsi & hdmi") in the mainline > (-rc3). Bah... that's what I get for not generating patches against linux-next. Thanks for letting me know. Thierry --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXaUjBAAoJEN0jrNd/PrOh8jcP/1lKqgzt2kh2A8G7MEciugHw zVa252cBLenqSbtk6aUNg/5Gbi4t0Ms/uEVvLJvzKBd8A1jCYXulKLNVex+Kq13i laFbr8C27BWavN73JWVR/jdRXK6wEHwyMCW8ADRuzFWXVVZueoLRfek12YvRaCMl tCkMyHi66TmIFim4iWYw3CduhxiHc92eJS2Orl/rOYSb+vK/XcYIADPw14ugvJ9E MYscA3T6kbwGZIznDRfoPkG8uH9c+j6351mHBxpzi8PeaeWGttpjRIzZ7KiqvwH3 J7y3n4XTKrNtxKrdmwkzSvnRcDGuvheWET8XrvjOoufDB2CRPmJk0fAeQBEvMssa Q3VM2y/DKswHFsNsr9kaJgOEzW41jcSDfgeiyncqS4v0Px5G7kgLMxt3ngHE+W8v j9587rQhZTeBwagDQ18IDkBLzRxNTsJC3OfhmMBvgVtw8ZLjODNfMcfNEJlm3BjX cNvuvUoA98SmefsD96EJ5nHE36UnDpD8qt0Hn+8edCHG9rezVX9lb3DXMEjOy7aQ rBuZfOAiZc32q2xkOdcQeJeT+db1v0Pb13tW68frrpeYmYa2vl7Hr1Rf5RHRYLgB 3bGWJT6vQ9kOkf3HytpNNboAlaHFp+8UMUmQK2u6exunueytpcAM0799+gXsNBgT HyPOdEPMU2Pe+XCWTMgb =j39e -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- --===============1229535019== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1229535019==--