From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] dmthin: express low_water in cluster_size not sector size
Date: Wed, 22 Jun 2016 10:03:52 +1000 [thread overview]
Message-ID: <20160622000352.GG27480@dastard> (raw)
In-Reply-To: <1466398386-5248-1-git-send-email-eguan@redhat.com>
On Mon, Jun 20, 2016 at 12:53:06PM +0800, Eryu Guan wrote:
> I noticed that thin-pool sent out "reached low water mark for data
> device" event even before thin-pool device was mounted in
> generic/347, this is because low water mark was set to a too high
> value.
>
> According to kernel thin-provisioning.txt documentation, low water
> mark should be expressed in blocks of $cluster_size, not in sectors.
>
> "$low_water_mark is expressed in blocks of size $data_block_size."
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-06-22 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 4:53 [PATCH] dmthin: express low_water in cluster_size not sector size Eryu Guan
2016-06-22 0:03 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622000352.GG27480@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.