Re: [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote:
> Hi Jerin,

Hi Thomas,

> 
> I wanted to push this patch which is now a dependency of ThunderX
> but I do not fully understand it.
> 
> 2016-03-31 02:21, Jerin Jacob:
> > - added VXLAN, GENEVE and NVGRE tunnel flow types
> > - added PORT flow type for accounting physical/virtual
> > port or channel number in flow creation
> [...]
> > --- a/lib/librte_ether/rte_eth_ctrl.h
> > +++ b/lib/librte_ether/rte_eth_ctrl.h
> > @@ -74,7 +74,11 @@ extern "C" {
> >  #define RTE_ETH_FLOW_IPV6_EX            15
> >  #define RTE_ETH_FLOW_IPV6_TCP_EX        16
> >  #define RTE_ETH_FLOW_IPV6_UDP_EX        17
> > -#define RTE_ETH_FLOW_MAX                18
> > +#define RTE_ETH_FLOW_PORT               18
> > +#define RTE_ETH_FLOW_VXLAN              19
> > +#define RTE_ETH_FLOW_GENEVE             20
> > +#define RTE_ETH_FLOW_NVGRE              21
> > +#define RTE_ETH_FLOW_MAX                22
> 
> Please could you explain more what is PORT flow?

For example, a NIC card with two physical port where application
configures RTE_ETH_FLOW_IPV4 for both, In that case
HW generate same RSS value for a similar IPV4 packet,  However, in-case if
application want to generate a flow that account physical port also then
it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT.

RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for
INBOUND traffic and other-one for OUTBOUND traffic etc


> Does it need a comment in the code?
Not sure, commit log has description.

Jerin