From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/5] scsi: make eh_eflags persistent
Date: Wed, 22 Jun 2016 15:33:10 +0200 [thread overview]
Message-ID: <20160622133309.GF6118@lst.de> (raw)
In-Reply-To: <1466415340-104465-4-git-send-email-hare@suse.de>
On Mon, Jun 20, 2016 at 11:35:38AM +0200, Hannes Reinecke wrote:
> To detect if a failed command has been retried we must not
> clear scmd->eh_eflags when EH finishes.
> The flag should be persistent throughout the lifetime
> of the command.
Please explain what issue this solves - the behavior has been there
for a while and even documented, so explaining how this was wrong
would be very useful.
next prev parent reply other threads:[~2016-06-22 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 9:35 [PATCH 0/5] SCSI EH cleanup Hannes Reinecke
2016-06-20 9:35 ` [PATCH 1/5] libsas: allow async aborts Hannes Reinecke
2016-06-20 9:35 ` [PATCH 2/5] scsi: make scsi_eh_scmd_add() always succeed Hannes Reinecke
2016-06-22 13:28 ` Christoph Hellwig
2016-06-20 9:35 ` [PATCH 3/5] scsi: make eh_eflags persistent Hannes Reinecke
2016-06-22 13:33 ` Christoph Hellwig [this message]
2016-06-20 9:35 ` [PATCH 4/5] scsi: make asynchronous aborts mandatory Hannes Reinecke
2016-06-22 13:31 ` Christoph Hellwig
2016-06-20 9:35 ` [PATCH 5/5] scsi: Do not escalate failed EH command Hannes Reinecke
2016-06-22 13:36 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-12-03 7:17 [PATCH 0/5] SCSI EH cleanup Hannes Reinecke
2015-12-03 7:17 ` [PATCH 3/5] scsi: make eh_eflags persistent Hannes Reinecke
2015-12-03 9:08 ` Johannes Thumshirn
2015-12-03 16:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622133309.GF6118@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.