From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@fb.com, shli@fb.com, snitzer@redhat.com, sitsofe@yahoo.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: introduce BLKDEV_DISCARD_ZERO to fix zeroout
Date: Wed, 22 Jun 2016 16:04:41 +0200 [thread overview]
Message-ID: <20160622140441.GA9484@lst.de> (raw)
In-Reply-To: <yq1h9cl1gan.fsf@sermon.lab.mkp.net>
On Wed, Jun 22, 2016 at 09:53:04AM -0400, Martin K. Petersen wrote:
> >>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
>
> Christoph,
>
> Christoph> Unlike discard outside the zeroout path, write same is a data
> Christoph> integrity operation. Just like in the zero out case turning
> Christoph> an EOPNOTSUPP into 0 will get you data corruption, as the
> Christoph> caller will see a successful return for an operation that did
> Christoph> not actually write data to disk.
>
> Exactly. So why add the dreaded -EOPNOTSUPP special casing to
> blkdev_issue_write_same()?
This is a leftover from bio_batch_end_io and not new behavior. But
I agree that we should kill it.
prev parent reply other threads:[~2016-06-22 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:28 [PATCH] block: introduce BLKDEV_DISCARD_ZERO to fix zeroout Christoph Hellwig
2016-06-20 18:29 ` Jeff Moyer
2016-06-21 12:39 ` Christoph Hellwig
2016-06-21 14:02 ` Jeff Moyer
2016-06-21 0:44 ` Martin K. Petersen
2016-06-21 12:40 ` Christoph Hellwig
2016-06-22 2:02 ` Martin K. Petersen
2016-06-22 7:52 ` Christoph Hellwig
2016-06-22 13:53 ` Martin K. Petersen
2016-06-22 14:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622140441.GA9484@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shli@fb.com \
--cc=sitsofe@yahoo.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.