From: Florian Westphal <fw@strlen.de>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables] configure: Fix logic to show connlabel support
Date: Wed, 22 Jun 2016 18:30:26 +0200 [thread overview]
Message-ID: <20160622163026.GC10213@breakpoint.cc> (raw)
In-Reply-To: <1466604637-26536-1-git-send-email-shivanib134@gmail.com>
Shivani Bhardwaj <shivanib134@gmail.com> wrote:
> With the earlier logic, when libnfnetlink and libnetfilter_conntrack
> were not installed, all the warnings showed up correctly but the final
> configuration showed:
>
> connlabel support: yes
>
> which was faulty.
> This was happening because connlabel module was blacklisted first and
> then set to "no" if package requirements were not met.
its because ...
> diff --git a/configure.ac b/configure.ac
> index c91e9e7..131bc8b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -173,9 +173,9 @@ if test "x$enable_connlabel" = "xyes"; then
> [nfconntrack=1], [nfconntrack=0])
>
> if test "$nfconntrack" -ne 1; then
> + enable_connlabel="no";
> blacklist_modules="$blacklist_modules connlabel";
> echo "WARNING: libnetfilter_conntrack not found, connlabel match will not be built";
> - enable_connlabel = "no";
... of the space around the '=', shell tried to execute
'enable_connlabel' command here.
next prev parent reply other threads:[~2016-06-22 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 14:10 [PATCH iptables] configure: Fix logic to show connlabel support Shivani Bhardwaj
2016-06-22 16:30 ` Florian Westphal [this message]
2016-06-22 16:45 ` Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160622163026.GC10213@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.