All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Liping Zhang <zlpnobody@gmail.com>,
	Liping Zhang <zlpnobody@163.com>,
	netfilter-devel@vger.kernel.org,
	Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PACTH nf-next] netfilter: nf_reject_ipv4: don't send tcp RST if the packet is non-TCP
Date: Thu, 23 Jun 2016 13:53:02 +0200	[thread overview]
Message-ID: <20160623115302.GA23847@salvia> (raw)
In-Reply-To: <20160621190301.GI18341@localhost.localdomain>

On Tue, Jun 21, 2016 at 04:03:01PM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Jun 21, 2016 at 09:35:55AM +0800, Liping Zhang wrote:
> > For example, when tcp->rst is set, reject_ip6 will call
> > pr_debug("RST is set\n"), while there's nothing in reject_ip4.
> > 
> > IMO, these debug informations are almost useless, so there's
> > no need to add this debug info only for consistent with nf_reject_ip6.
> 
> Fair enough. Although I did the comment, I don't have a strong opinion
> on this.

I'd take a patch to get rid of those pr_debug() in nf_reject_ip6.

Thanks.

  reply	other threads:[~2016-06-23 11:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 13:26 [PACTH nf-next] netfilter: nf_reject_ipv4: don't send tcp RST if the packet is non-TCP Liping Zhang
2016-06-20 15:48 ` Marcelo Ricardo Leitner
2016-06-21  1:35   ` Liping Zhang
2016-06-21 19:03     ` Marcelo Ricardo Leitner
2016-06-23 11:53       ` Pablo Neira Ayuso [this message]
2016-06-23 17:33 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160623115302.GA23847@salvia \
    --to=pablo@netfilter.org \
    --cc=liping.zhang@spreadtrum.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=zlpnobody@163.com \
    --cc=zlpnobody@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.