From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [PATCH] x86: fix unused efi_get_time function Date: Thu, 23 Jun 2016 14:32:05 +0100 Message-ID: <20160623133205.GH8415@codeblueprint.co.uk> References: <20160617145152.3569706-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160617145152.3569706-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: Arnd Bergmann Cc: linux-efi@vger.kernel.org, Ard Biesheuvel , y2038@lists.linaro.org, x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner List-Id: linux-efi@vger.kernel.org T24gRnJpLCAxNyBKdW4sIGF0IDA0OjUxOjI5UE0sIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gTm90 aGluZyBjYWxscyB0aGUgZWZpX2dldF90aW1lIGZ1bmN0aW9uIG9uIHg4NiwgYnV0IGl0IGRvZXMg c3VmZmVyCj4gZnJvbSB0aGUgMzItYml0IHRpbWVfdCBvdmVyZmxvdyBpbiAyMDM4Lgo+IAo+IFRv IGF2b2lkIHRoYXQgaWYgYW55b25lIHN0YXJ0cyBjYWxsaW5nIGl0LCB0aGlzIGNoYW5nZXMgdGhl IGZ1bmN0aW9uCj4gdG8gdXNlIHRpbWVzcGVjNjQgYW5kIG1rdGltZTY0IGluc3RlYWQuCj4gCj4g U2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiAtLS0KPiBUaGUg b2J2aW91cyBhbHRlcm5hdGl2ZSB3b3VsZCBiZSB0byByZW1vdmUgdGhlIGZ1bmN0aW9uLCBJJ2xs IHNlbmQKPiB0aGF0IHBhdGNoIGFzIHdlbGwsIHNvIHlvdSBjYW4gcGljayBvbmUgb3IgdGhlIG90 aGVyLgo+IAo+ICBhcmNoL3g4Ni9wbGF0Zm9ybS9lZmkvZWZpLmMgfCA2ICsrKy0tLQo+ICBpbmNs dWRlL2xpbnV4L2VmaS5oICAgICAgICAgfCAyICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQogCkxvb2tzIGdvb2QsIHRoYW5rcyBBcm5kIQpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpZMjAzOCBtYWlsaW5n IGxpc3QKWTIwMzhAbGlzdHMubGluYXJvLm9yZwpodHRwczovL2xpc3RzLmxpbmFyby5vcmcvbWFp bG1hbi9saXN0aW5mby95MjAzOAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbcFWNcP (ORCPT ); Thu, 23 Jun 2016 09:32:15 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:34942 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcFWNcN (ORCPT ); Thu, 23 Jun 2016 09:32:13 -0400 Date: Thu, 23 Jun 2016 14:32:05 +0100 From: Matt Fleming To: Arnd Bergmann Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, y2038@lists.linaro.org, Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: fix unused efi_get_time function Message-ID: <20160623133205.GH8415@codeblueprint.co.uk> References: <20160617145152.3569706-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160617145152.3569706-1-arnd@arndb.de> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun, at 04:51:29PM, Arnd Bergmann wrote: > Nothing calls the efi_get_time function on x86, but it does suffer > from the 32-bit time_t overflow in 2038. > > To avoid that if anyone starts calling it, this changes the function > to use timespec64 and mktime64 instead. > > Signed-off-by: Arnd Bergmann > --- > The obvious alternative would be to remove the function, I'll send > that patch as well, so you can pick one or the other. > > arch/x86/platform/efi/efi.c | 6 +++--- > include/linux/efi.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) Looks good, thanks Arnd!