From: Wei Liu <wei.liu2@citrix.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Iurii Konovalenko <iurii.konovalenko@globallogic.com>,
Dirk Behme <dirk.behme@de.bosch.com>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Tim Deegan <tim@xen.org>,
Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 1/2] xen/arm: drivers: scif: Remove dead code
Date: Thu, 23 Jun 2016 16:18:01 +0100 [thread overview]
Message-ID: <20160623151801.GE13180@citrix.com> (raw)
In-Reply-To: <576BFBB3.4080307@arm.com>
On Thu, Jun 23, 2016 at 04:09:39PM +0100, Julien Grall wrote:
> (CC "THE REST" maintainers)
>
> Hi Dirk,
>
> On 22/06/16 12:49, Dirk Behme wrote:
> >The two struct members baud and clock_hz are in the end read only
> >variables nowhere used for anything useful. Removing them makes
> >the code much simpler without changing any functionality.
> >
> >Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>
> Note that technically this driver is supported by "THE REST" maintainers. It
> might be worth to add it under "ARM (W/ VIRTUALISATION EXTENSIONS)
> ARCHITECTURE" as it is already the case for the other ARM specific UART
> drivers.
>
FWIW this sounds reasonable to me.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-23 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 11:49 [PATCH v3 1/2] xen/arm: drivers: scif: Remove dead code Dirk Behme
2016-06-22 11:49 ` [PATCH v3 2/2] xen/arm: drivers: scif: Don't overwrite firmware settings Dirk Behme
2016-06-23 15:10 ` Julien Grall
2016-06-23 15:09 ` [PATCH v3 1/2] xen/arm: drivers: scif: Remove dead code Julien Grall
2016-06-23 15:18 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623151801.GE13180@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dirk.behme@de.bosch.com \
--cc=george.dunlap@citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=julien.grall@arm.com \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.