From: Andi Kleen <ak@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 0/3] perf script: Add callindent option
Date: Thu, 23 Jun 2016 09:18:04 -0700 [thread overview]
Message-ID: <20160623161804.GF25121@tassilo.jf.intel.com> (raw)
In-Reply-To: <1466689258-28493-1-git-send-email-adrian.hunter@intel.com>
On Thu, Jun 23, 2016 at 04:40:55PM +0300, Adrian Hunter wrote:
> Hi
>
> Andi Kleen sent a couple of patches to add a callindent option to
> perf script. Andi was agreeable to this alternative implementation.
>
> While there are some differences in the resulting output, the main
> difference is:
>
> 1. Tell the decoder to feed branches to the thread stack, which has the
> advantage that it happens before branch filtering and so can be used
> with different itrace options (e.g. it still works when only showing
> calls, even though the thread stack needs to see calls and returns). Also
> it does not conflict with using the thread stack to get callchains.
Looks all good to me.
Acked-by: Andi Kleen <ak@linux.intel.com>
Thanks,
-Andi
prev parent reply other threads:[~2016-06-23 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 13:40 [PATCH V2 0/3] perf script: Add callindent option Adrian Hunter
2016-06-23 13:40 ` [PATCH V2 1/3] perf script: Print sample flags more nicely Adrian Hunter
2016-06-26 10:59 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-06-23 13:40 ` [PATCH V2 2/3] perf auxtrace: Add option to feed branches to the thread stack Adrian Hunter
2016-06-26 10:59 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-06-23 13:40 ` [PATCH V2 3/3] perf script: Add callindent option Adrian Hunter
2016-06-23 14:09 ` Arnaldo Carvalho de Melo
2016-06-23 16:20 ` Andi Kleen
2016-06-23 16:46 ` Arnaldo Carvalho de Melo
2016-06-26 11:00 ` [tip:perf/core] " tip-bot for Adrian Hunter
2016-06-23 16:18 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623161804.GF25121@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.