From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, zlpnobody@gmail.com
Subject: Re: [PATCH -next v3] netfilter: conntrack: allow increasing bucket size via sysctl too
Date: Thu, 23 Jun 2016 19:41:03 +0200 [thread overview]
Message-ID: <20160623174103.GA3620@salvia> (raw)
In-Reply-To: <1466594770-8610-1-git-send-email-fw@strlen.de>
On Wed, Jun 22, 2016 at 01:26:10PM +0200, Florian Westphal wrote:
> No need to restrict this to module parameter.
>
> We export a copy of the real hash size -- when user alters the value we
> allocate the new table, copy entries etc before we update the real size
> to the requested one.
>
> This is also needed because the real size is used by concurrent readers
> and cannot be changed without synchronizing the conntrack generation
> seqcnt.
>
> We only allow changing this value from the initial net namespace.
>
> Tested using http-client-benchmark vs. httpterm with concurrent
>
> while true;do
> echo $RANDOM > /proc/sys/net/netfilter/nf_conntrack_buckets
> done
Applied, thanks Florian.
prev parent reply other threads:[~2016-06-23 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 11:26 [PATCH -next v3] netfilter: conntrack: allow increasing bucket size via sysctl too Florian Westphal
2016-06-23 17:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623174103.GA3620@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.