From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586AbcFWUr5 (ORCPT ); Thu, 23 Jun 2016 16:47:57 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:32954 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244AbcFWUrz (ORCPT ); Thu, 23 Jun 2016 16:47:55 -0400 Date: Thu, 23 Jun 2016 13:47:52 -0700 From: Dmitry Torokhov To: John Stultz Cc: Jorge Ramirez-Ortiz , lkml , Rob Herring , Lee Jones , Feng Chen , Wei Xu , Guodong Xu Subject: Re: [PATCH 1/4] drivers: input: powerkey for HISI 65xx SoC Message-ID: <20160623204752.GN32561@dtor-ws> References: <1465944212-17079-1-git-send-email-john.stultz@linaro.org> <1465944212-17079-2-git-send-email-john.stultz@linaro.org> <20160623004716.GA26808@dtor-ws> <20160623204022.GM32561@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160623204022.GM32561@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 01:40:22PM -0700, Dmitry Torokhov wrote: > On Thu, Jun 23, 2016 at 01:31:28PM -0700, John Stultz wrote: > > On Wed, Jun 22, 2016 at 5:47 PM, Dmitry Torokhov > > wrote: > > > On Tue, Jun 21, 2016 at 05:06:23PM -0700, John Stultz wrote: > > >> On Tue, Jun 14, 2016 at 3:43 PM, John Stultz wrote: > > >> > From: Jorge Ramirez-Ortiz > > >> > > > >> > This driver provides a input driver for the power button on the > > >> > HiSi 65xx SoC for boards like HiKey. > > >> > > > >> > This driver was originally by Zhiliang Xue > > >> > then basically rewritten by Jorge, but preserving the original > > >> > module author credits. > > >> > > > >> > Cc: Dmitry Torokhov > > >> > Cc: Rob Herring > > >> > Cc: Lee Jones > > >> > Cc: Jorge Ramirez-Ortiz > > >> > Cc: Feng Chen > > >> > Cc: Wei Xu > > >> > Cc: Guodong Xu > > >> > Signed-off-by: Jorge Ramirez-Ortiz > > >> > [jstultz: Reworked commit message, folded in other fixes/cleanups > > >> > from Jorge, implemented some larger cleanups suggested by DmitryT] > > >> > Signed-off-by: John Stultz > > >> > --- > > >> > v2: Major rework integrating feedback from Dmitry. > > >> > v3: Dropped of_match compatible line since no longer using DT > > >> > for this. > > >> > v4: Removed MODULE_DEVICE_TABLE(of, hi65xx_powerkey_of_match) line > > >> > I missed in the last revision, which casued build issues w/ > > >> > modules. > > >> > > >> Hey Dmitry, > > >> Just wanted to ping you to see if there was anything else you were > > >> wanting changed with this patch. Lee has queued the mfd patches in > > >> -next, so I wanted to be sure to address any concerns you had that was > > >> keeping this from heading upstream in 4.8 (hopefully :). > > > > > > Right, sorry, does the following look OK to you? > > > > > > > Yes! It looks great (and I tested it works too)! > > > > Do you want to fold that in, or do you need me to re-submit with those changes? > > I'll fold it in on my side. Thank you for testing it! Changed the config symbol to INPUT_HISI_POWERKEY to match other symbols in drivers/input/misc and queued for the next merge window. Thanks. -- Dmitry