From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbcFXCjR (ORCPT ); Thu, 23 Jun 2016 22:39:17 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52654 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbcFXCjP (ORCPT ); Thu, 23 Jun 2016 22:39:15 -0400 X-Sasl-enc: tZER/0Y1btV4kC2SFppYdctTZFFGwPTYq5Lk8HPmEp3h 1466735954 Date: Thu, 23 Jun 2016 19:39:13 -0700 From: Greg KH To: tech@winchiphead.com Cc: johan@kernel.org, gregkh@linuxfoundation.rog, konstantin.shkolnyy@gmail.com, pberger@brimson.com, david.ward@ll.mit.edu, m.othacehe@gmail.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: serial: update CH34x driver in drivers/usb/serial Message-ID: <20160624023913.GA30063@kroah.com> References: <1466732874-12649-1-git-send-email-tech@winchiphead.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466732874-12649-1-git-send-email-tech@winchiphead.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2016 at 06:47:54PM -0700, tech@winchiphead.com wrote: > The old driver for usb-serial chips ch34x which submitted by kernel volunteer > Frank A Kingswood is too old to use, and the > driver has bugs when receiving chracters, thus after communicating with the author > we decide to revoke the old driver ch341.c and submit the new one ch34x.c. "revoke"? Why not just fix the bugs in the existing one instead? That would be a much smaller patch, and much easier to review. > Add the relevant details to Documentation/usb/usb-serial.txt. > Change the relevant files Kconfig and Makefile in drivers/usb/serial. > > Signed-off-by: WCH Tech Group This has to be a person, it can not be a company, or any other anonymous email address, sorry. Same with your "From:" address. thanks, greg k-h