From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbcFXMzm (ORCPT ); Fri, 24 Jun 2016 08:55:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42317 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbcFXMzl (ORCPT ); Fri, 24 Jun 2016 08:55:41 -0400 Date: Fri, 24 Jun 2016 14:55:38 +0200 From: Jiri Olsa To: pi3orama Cc: Wang Nan , acme@kernel.org, linux-kernel@vger.kernel.org, lizefan@huawei.com Subject: Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Message-ID: <20160624125538.GA18012@krava> References: <1466767332-114472-1-git-send-email-wangnan0@huawei.com> <20160624122907.GF10142@krava> <887CD4AB-AD56-40A0-9DD1-93D0767474B3@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <887CD4AB-AD56-40A0-9DD1-93D0767474B3@163.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 24 Jun 2016 12:55:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 08:33:27PM +0800, pi3orama wrote: SNIP > > I can't compile unless I can include config.h > > > > [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1 > > BUILD: Doing 'make -j4' parallel build > > CC util/data-convert-bt.o > > util/data-convert-bt.c: In function ‘convert__config’: > > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration] > > c->queue_size = perf_config_u64(var, value); > > ^ > > util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs] > > c->queue_size = perf_config_u64(var, value); > > ^ > > util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’: > > util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration] > > perf_config(convert__config, &c); > > ^ > > util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs] > > cc1: all warnings being treated as errors > > > > Strange. > > The error message seems unrelated to my > patch, right? yep, it's unrelated and I just posted the fix I haven't enabled/compiled this code for a while and that's what I've got.. I assume we're using different compilers jirka