From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbcFXNIT (ORCPT ); Fri, 24 Jun 2016 09:08:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49508 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbcFXNIR (ORCPT ); Fri, 24 Jun 2016 09:08:17 -0400 Date: Fri, 24 Jun 2016 15:08:14 +0200 From: Jiri Olsa To: pi3orama Cc: Arnaldo Carvalho de Melo , Wang Nan , linux-kernel@vger.kernel.org, lizefan@huawei.com Subject: Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Message-ID: <20160624130814.GA18487@krava> References: <1466767332-114472-1-git-send-email-wangnan0@huawei.com> <20160624122907.GF10142@krava> <20160624124113.GA3324@kernel.org> <19E23F84-F70D-42EE-9F5E-E580AD39C90A@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <19E23F84-F70D-42EE-9F5E-E580AD39C90A@163.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 24 Jun 2016 13:08:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 08:43:56PM +0800, pi3orama wrote: > > > 发自我的 iPhone > > > 在 2016年6月24日,下午8:41,Arnaldo Carvalho de Melo 写道: > > > > Em Fri, Jun 24, 2016 at 02:29:07PM +0200, Jiri Olsa escreveu: > >> On Fri, Jun 24, 2016 at 11:22:05AM +0000, Wang Nan wrote: > >>> After converting perf.data to CTF, we lost pid-tid-comm mapping. Which > >>> makes inconvience. For example, in perf script output we know which > >>> process issue an event like this: > >>> > >>> compiz 19361 [001] 3275709.313929: raw_syscalls:sys_exit: NR 7 = 0 > >>> > >>> After converting to CTF, we only get this: > >>> > >>> [3275709.313929985] (+0.110646118) raw_syscalls:sys_exit: { cpu_id = 1 }, { perf_ip = 0xFFFFFFFF8107B2E8, perf_tid = 19361, perf_pid = 19361, perf_id = 18920, perf_period = 1, common_type = 16, common_flags = 0, common_preempt_count = 1, common_pid = 19361, id = 7, ret = 0 } > >>> > >>> Currently, if we want to find the name and parent of a process, we > >>> have to collect 'sched:sched_switch' event. > >>> > >>> This patch set adds a '--all' option to 'perf convert', converts comm, > >>> fork and exit events to CTF output. CTF user now can track the mapping > >>> by their own. > >>> > >>> v1 -> v2: Report number of sample and non-sample events when finish. > >>> rename opts.non_sample to opts.all. > >>> > >>> Wang Nan (7): > >>> perf ctf: Add value_set_string() helper > >>> perf ctf: Pass convert options through opts structure > >>> perf ctf: Add 'all' option > >>> perf ctf: Prepare collect non-sample events > >>> perf ctf: Generate comm event to CTF output > >>> perf ctf: Add '--all' option for 'perf data convert' > >>> perf ctf: Generate fork and exit events to CTF output > >> > >> I can't compile unless I can include config.h > > > > Waiting for this fix to proceed, but it seems we don't have this covered > > in 'build-test', right? ;-) > > > > CTF support is off by default. When can we > turn it on like other options? we switched it off because the latest version we needed wasn't part of main distros.. it might have changed now jirka