From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [RFC 0/5] rework fences on struct sync_file Date: Fri, 24 Jun 2016 10:17:24 -0300 Message-ID: <20160624131724.GA2503@joana> References: <1466695790-2833-1-git-send-email-gustavo@padovan.org> <576CFD0B.6000501@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.161.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB6DF6EABA for ; Fri, 24 Jun 2016 13:17:29 +0000 (UTC) Received: by mail-yw0-f171.google.com with SMTP id i12so96731072ywa.1 for ; Fri, 24 Jun 2016 06:17:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <576CFD0B.6000501@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXN0aWFuLAoKMjAxNi0wNi0yNCBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29l bmlnQGFtZC5jb20+OgoKPiBBbSAyMy4wNi4yMDE2IHVtIDE3OjI5IHNjaHJpZWIgR3VzdGF2byBQ YWRvdmFuOgo+ID4gRnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFi b3JhLmNvLnVrPgo+ID4gCj4gPiBIaSBhbGwsCj4gPiAKPiA+IFRoaXMgaXMgYW4gYXR0ZW1wdCB0 byBpbXByb3ZlIGZlbmNlIHN1cHBvcnQgb24gU3luYyBGaWxlLiBUaGUgYmFzaWMgaWRlYQo+ID4g aXMgdG8gaGF2ZSBvbmx5IHN5bmNfZmlsZS0+ZmVuY2UgYW5kIHN0b3JlIGFsbCBmZW5jZXMgdGhl cmUsIGVpdGhlciBhcwo+ID4gbm9ybWFsIGZlbmNlcyBvciBmZW5jZV9hcnJheXMuIFRoYXQgd2F5 IHdlIGNhbiByZW1vdmUgc29tZSBwb3RlbnRpYWwKPiA+IGR1cGxpY2F0aW9uIHdoZW4gdXNpbmcg ZmVuY2VfYXJyYXkgd2l0aCBzeW5jX2ZpbGU6IHRoZSBkdXBsaWNhdGlvbiBvZiB0aGUgYXJyYXkK PiA+IG9mIGZlbmNlcyBhbmQgdGhlIGR1cGxpY2F0aW9uIG9mIGZlbmNlX2FkZF9jYWxsYmFjaygp IGZvciBhbGwgZmVuY2VzLgo+ID4gCj4gPiBOb3cgd2hlbiBjcmVhdGluZyBhIG5ldyBzeW5jX2Zp bGUgZHVyaW5nIHRoZSBtZXJnZSBwcm9jZXNzIHN5bmNfZmlsZV9zZXRfZmVuY2UoKQo+ID4gd2ls bCBzZXQgc3luY19maWxlLT5mZW5jZSBiYXNlZCBvbiB0aGUgbnVtYmVyIG9mIGZlbmNlcyBmb3Ig dGhhdCBzeW5jX2ZpbGUuIElmCj4gPiB0aGVyZSBpcyBtb3JlIHRoYW4gb25lIGZlbmNlIGEgZmVu Y2VfYXJyYXkgaXMgY3JlYXRlZC4gT25lIGltcG9ydGFudCBhZHZhbnRhZ2UKPiA+IGFwcHJvYWNo IGlzIHRoYXQgd2Ugb25seSBhZGQgb25lIGZlbmNlIGNhbGxiYWNrIG5vdywgbm8gbWF0dGVyIGhv dyBtYW55IGZlbmNlcwo+ID4gdGhlcmUgYXJlIGluIGEgc3luY19maWxlIC0gdGhlIGluZGl2aWR1 YWwgY2FsbGJhY2tzIGFyZSBhZGRlZCBieSBmZW5jZV9hcnJheS4KPiA+IAo+ID4gVHdvIGZlbmNl IG9wcyBoYWQgdG8gYmUgY3JlYXRlZCB0byBoZWxwIGFic3RyYWN0IHRoZSBkaWZmZXJlbmNlIGJl dHdlZW4gaGFuZGxpbmcKPiA+IGZlbmNlcyBhbmQgZmVuY2VzX2FycmF5czogLnRlYXJkb3duKCkg YW5kIC5nZXRfZmVuY2VzKCkuIFRoZSBmb3JtZXIgcnVuIG5lZWRlZAo+ID4gb24gZmVuY2VfYXJy YXksIGFuZCB0aGUgbGF0dGVyIGp1c3QgcmV0dXJuIGEgY29weSBvZiBhbGwgZmVuY2VzIGluIHRo ZSBmZW5jZS4KPiA+IEknbSBub3Qgc28gc3VyZSBhYm91dCBhZGRpbmcgdGhvc2UgdHdvLCBzcGVh Y2lhbGx5IC5nZXRfZmVuY2VzKCkuIFdoYXQgZG8geW91Cj4gPiB0aGluaz8KPiAKPiBDbGVhcmx5 IG5vdCBhIGdvb2QgaWRlYSB0byBhZGQgdGhpcyBhIGZlbmNlIG9wcywgY2F1c2UgdGhvc2UgYXJl IHNwZWNpYWxpemVkCj4gZnVuY3Rpb25zIGZvciBvbmx5IGEgY2VydGFpbiBmZW5jZSBpbXBsZW1l bnRhdGlvbiAodGhlIGZlbmNlX2FycmF5KS4KCkFyZSB5b3UgcmVmZXJpbmcgb25seSB0byAuZ2V0 X2ZlbmNlcygpPwoKPiAKPiBXaGF0IHlvdSBzaG91bGQgZG8gaXMgdHJ5IHRvIGNhc3QgdGhlIGZl bmNlIGluIHlvdXIgc3luYyBmaWxlIHVzaW5nCj4gdG9fZmVuY2VfYXJyYXkoKSBhbmQgdGhlbiB5 b3UgY2FuIGFjY2VzcyB0aGUgZmVuY2VzIGluIHRoZSBhcnJheS4KClllcywgdGhhdCBzZWVtcyBh IGJldHRlciBpZGVhIEkgdGhpbmsuIFRoZSBpbml0aWFsIGlkZWEgd2FzIHRvIGFic3RyYWN0ICAg ICAgICAgCnRoZSBkaWZmZXJlbmNlIGFzIG11Y2ggYXMgcG9zc2libGUsIGJ1dCBpdCBkb2Vzbid0 IHNlZW0gcmVhbGx5IHdvcnRoICAgICAgICAgICAgCmZvciAuZ2V0X2ZlbmNlcygpLgoKCUd1c3Rh dm8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbcFXNRa (ORCPT ); Fri, 24 Jun 2016 09:17:30 -0400 Received: from mail-yw0-f180.google.com ([209.85.161.180]:33615 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbcFXNR3 convert rfc822-to-8bit (ORCPT ); Fri, 24 Jun 2016 09:17:29 -0400 Date: Fri, 24 Jun 2016 10:17:24 -0300 From: Gustavo Padovan To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com Subject: Re: [RFC 0/5] rework fences on struct sync_file Message-ID: <20160624131724.GA2503@joana> Mail-Followup-To: Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com References: <1466695790-2833-1-git-send-email-gustavo@padovan.org> <576CFD0B.6000501@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <576CFD0B.6000501@amd.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, 2016-06-24 Christian König : > Am 23.06.2016 um 17:29 schrieb Gustavo Padovan: > > From: Gustavo Padovan > > > > Hi all, > > > > This is an attempt to improve fence support on Sync File. The basic idea > > is to have only sync_file->fence and store all fences there, either as > > normal fences or fence_arrays. That way we can remove some potential > > duplication when using fence_array with sync_file: the duplication of the array > > of fences and the duplication of fence_add_callback() for all fences. > > > > Now when creating a new sync_file during the merge process sync_file_set_fence() > > will set sync_file->fence based on the number of fences for that sync_file. If > > there is more than one fence a fence_array is created. One important advantage > > approach is that we only add one fence callback now, no matter how many fences > > there are in a sync_file - the individual callbacks are added by fence_array. > > > > Two fence ops had to be created to help abstract the difference between handling > > fences and fences_arrays: .teardown() and .get_fences(). The former run needed > > on fence_array, and the latter just return a copy of all fences in the fence. > > I'm not so sure about adding those two, speacially .get_fences(). What do you > > think? > > Clearly not a good idea to add this a fence ops, cause those are specialized > functions for only a certain fence implementation (the fence_array). Are you refering only to .get_fences()? > > What you should do is try to cast the fence in your sync file using > to_fence_array() and then you can access the fences in the array. Yes, that seems a better idea I think. The initial idea was to abstract the difference as much as possible, but it doesn't seem really worth for .get_fences(). Gustavo