All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/13 v7] core/legal-info: also save patches
Date: Fri, 24 Jun 2016 16:22:01 +0200	[thread overview]
Message-ID: <20160624162201.5e10d065@free-electrons.com> (raw)
In-Reply-To: <d280d1c64b43031e31feef82091e5bb59ba43d86.1462637351.git.yann.morin.1998@free.fr>

Hello,

On Sat,  7 May 2016 18:14:33 +0200, Yann E. MORIN wrote:
> Currently, the legal-info infra only saves the source archive of a
> package. However, that's not enough as we may apply some patches on
> packages sources.
> 
> We do suggest users to also redistribute the Buildroot sources as part
> of their compliance distribution, so the patches bundled in Buildroot
> would indeed be included in the compliance distribution.
> 
> However, that's still not enough, since we may download some patches, or
> the user may use a global patch directory. Patches in there might not
> end up in the compliance distribution, and there are risks of
> non-conformity.
> 
> So, always include patches alongside the source archive.
> 
> To ensure reproducibility, we also generate a series file, so patches
> can be re-applied in the correct order.
> 
> We get the list of patches to include from the list of patches that were
> applied by the package infrastructure (via the apply-patches support
> script). So, we need to get packages properly extracted and patched
> before we can save their legal-info, not just in the case they define
> _LICENSE_FILES.
> 
> Update the legal-info header accordingly.
> 
> Note: this means that, when a package is not patched and defines no
> LICENSE_FILES, we will extract and patch it for nothing. There is no
> easy way to know whether we have to patch a package or not. We can only
> either duplicate the logic to detect patches (bad) or rely on the infra
> actually patching the package. Also, a vast majority of packages are
> either patched, or define _LICENSE_FILES, so it is best and easiest to
> always extract and patch them prior to legal-info.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Luca Ceresoli <luca@lucaceresoli.net>
> Tested-by: Luca Ceresoli <luca@lucaceresoli.net>
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
> 
> ---
> Changes v6 -> v7:
>   - directly call the helper

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2016-06-24 14:22 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 16:14 [Buildroot] [PATCH 00/13 v7] legal-info improvements and completeness (branch yem/legal-4) Yann E. MORIN
2016-05-07 16:14 ` [Buildroot] [PATCH 01/13 v7] support/scripts: add helper to hardlink-or-copy Yann E. MORIN
2016-05-07 18:48   ` Arnout Vandecappelle
2016-05-11 21:23   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 02/13 v7] core/legal-info: use the helper to install source archives Yann E. MORIN
2016-05-07 19:54   ` Arnout Vandecappelle
2016-05-11 21:24   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 03/13 v7] core/pkg-generic: add variable to store the package rawname-version Yann E. MORIN
2016-05-11 21:29   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 04/13 v7] core/legal-info: install source archives in their own sub-dir Yann E. MORIN
2016-05-11 21:40   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 05/13 v7] core/legal-info: add package version to license directory Yann E. MORIN
2016-05-07 20:01   ` Arnout Vandecappelle
2016-05-11 21:43     ` Thomas Petazzoni
2016-05-13 20:11       ` Yann E. MORIN
2016-05-14 21:22         ` Arnout Vandecappelle
2016-05-15  9:49           ` Yann E. MORIN
2016-05-15 17:50           ` Yann E. MORIN
2016-05-16 21:31             ` Arnout Vandecappelle
2016-06-24 13:50   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 06/13 v7] core/apply-patches: store full path of applied patches Yann E. MORIN
2016-05-07 20:09   ` Arnout Vandecappelle
2016-06-22 20:59     ` Yann E. MORIN
2016-06-24 14:02   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 07/13 v7] support/apply-patches: bail-out on duplicate patch basenames Yann E. MORIN
2016-05-07 20:16   ` Arnout Vandecappelle
2016-06-22 21:01     ` Yann E. MORIN
2016-06-24 14:09   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 08/13 v7] core/legal-info: also save patches Yann E. MORIN
2016-05-07 20:36   ` Arnout Vandecappelle
2016-06-22 21:03     ` Yann E. MORIN
2016-06-24 14:22   ` Thomas Petazzoni [this message]
2016-05-07 16:14 ` [Buildroot] [PATCH 09/13 v7] core/legal-info: also save extra downloads Yann E. MORIN
2016-05-07 20:42   ` Arnout Vandecappelle
2016-06-24 14:22   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 10/13 v7] legal-info: explicitly state how patches are licensed Yann E. MORIN
2016-06-24 14:25   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 11/13 v7] core/legal-info: generate a hash of all saved files Yann E. MORIN
2016-06-24 15:08   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 12/13 v7] core/pkg-generic: reorder variables definitions for legal-info Yann E. MORIN
2016-06-24 15:10   ` Thomas Petazzoni
2016-05-07 16:14 ` [Buildroot] [PATCH 13/13 v7] core/legal-info: ensure legal-info works in off-line mode Yann E. MORIN
2016-06-24 15:11   ` Thomas Petazzoni
2016-06-22 21:12 ` [Buildroot] [PATCH 00/13 v7] legal-info improvements and completeness (branch yem/legal-4) Yann E. MORIN
2016-06-24 15:11 ` Thomas Petazzoni
2016-06-24 17:20   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624162201.5e10d065@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.