From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:49455 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbcFYQJh (ORCPT ); Sat, 25 Jun 2016 12:09:37 -0400 Date: Sat, 25 Jun 2016 09:09:39 -0700 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Jiri Slaby , Magnus Damm , Yoshihiro Shimoda , linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp Subject: Re: [PATCH v2 2/4] serial: sh-sci: Stop transfers in sci_shutdown() Message-ID: <20160625160939.GA29593@kroah.com> References: <1466780356-12623-1-git-send-email-geert+renesas@glider.be> <1466780356-12623-3-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466780356-12623-3-git-send-email-geert+renesas@glider.be> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Fri, Jun 24, 2016 at 04:59:14PM +0200, Geert Uytterhoeven wrote: > Make sure the transmitter and receiver are stopped when shutting down > the port, and related interrupts are disabled. > > Without this: > - New input data may be received into the RX FIFO, possibly > triggering a new RX DMA completion, > - Transfers will still be enabled on a subsequent startup of the UART, > before the UART's FIFOs have been reset, causing reading of stale > data. > > Inspired by a patch in the BSP by Koji Matsuoka > . > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Do not clear clock source bits, since the serial console relies on > them, as reported by Shimoda-san. > > v1 was extracted from "[PATCH/RFC v3 0/4] serial: sh-sci: Add DT DMA > support". The issues with the serial console seen before on > r8a7740/armadillo and sh73a0/kzm9g seem to be gone. Changes after > resurrection: > - Write zero to also disable related interrupts, as suggested by > Laurent Pinchart, > - Enhanced patch description. > --- > drivers/tty/serial/sh-sci.c | 5 +++++ > 1 file changed, 5 insertions(+) This patch does not apply to my tree :( From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Sat, 25 Jun 2016 16:09:39 +0000 Subject: Re: [PATCH v2 2/4] serial: sh-sci: Stop transfers in sci_shutdown() Message-Id: <20160625160939.GA29593@kroah.com> List-Id: References: <1466780356-12623-1-git-send-email-geert+renesas@glider.be> <1466780356-12623-3-git-send-email-geert+renesas@glider.be> In-Reply-To: <1466780356-12623-3-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Jiri Slaby , Magnus Damm , Yoshihiro Shimoda , linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp On Fri, Jun 24, 2016 at 04:59:14PM +0200, Geert Uytterhoeven wrote: > Make sure the transmitter and receiver are stopped when shutting down > the port, and related interrupts are disabled. > > Without this: > - New input data may be received into the RX FIFO, possibly > triggering a new RX DMA completion, > - Transfers will still be enabled on a subsequent startup of the UART, > before the UART's FIFOs have been reset, causing reading of stale > data. > > Inspired by a patch in the BSP by Koji Matsuoka > . > > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Do not clear clock source bits, since the serial console relies on > them, as reported by Shimoda-san. > > v1 was extracted from "[PATCH/RFC v3 0/4] serial: sh-sci: Add DT DMA > support". The issues with the serial console seen before on > r8a7740/armadillo and sh73a0/kzm9g seem to be gone. Changes after > resurrection: > - Write zero to also disable related interrupts, as suggested by > Laurent Pinchart, > - Enhanced patch description. > --- > drivers/tty/serial/sh-sci.c | 5 +++++ > 1 file changed, 5 insertions(+) This patch does not apply to my tree :(