Re: [PATCH 1/2] perf data convert: Include config.h header

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Sat, Jun 25, 2016 at 09:29:04AM +0800, Wangnan (F) escreveu:
> You can add:
> 
> Fixes: 41840d211c51 ("perf config: Move config declarations from
> util/cache.h to util/config.h")

Yeah, I'll do that, thanks for pointing it out!

- Arnaldo
 
> Thank you.
> 
> On 2016/6/24 20:40, Jiri Olsa wrote:
> > otherwise some compiler might scream:
> > 
> >    $ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> >      BUILD:   Doing 'make -j4' parallel build
> >      CC       util/data-convert-bt.o
> >    util/data-convert-bt.c: In function ‘convert__config’:
> >    util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> >       c->queue_size = perf_config_u64(var, value);
> >    ...
> > 
> > Link: http://lkml.kernel.org/n/tip-t9dyx71w49dy5tacpdzr5b2p@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >   tools/perf/util/data-convert-bt.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> > index 9f53020c3269..5186bb1168af 100644
> > --- a/tools/perf/util/data-convert-bt.c
> > +++ b/tools/perf/util/data-convert-bt.c
> > @@ -26,6 +26,7 @@
> >   #include "evlist.h"
> >   #include "evsel.h"
> >   #include "machine.h"
> > +#include "config.h"
> >   #define pr_N(n, fmt, ...) \
> >   	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)
>