From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 0/7] de-stage SW_SYNC validation frawework Date: Sun, 26 Jun 2016 23:45:04 +0200 Message-ID: <20160626214504.GA21026@amd> References: <1466437993-21573-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 337C86E0BD for ; Sun, 26 Jun 2016 21:45:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1466437993-21573-1-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org SGkhCgo+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5j by51az4KPiAKPiBIaSBHcmVnLAo+IAo+IFRoaXMgaXMgdGhlIGxhc3Qgc3RlcCBpbiB0aGUgU3lu YyBGcmFtd29yayBkZS1zdGFnZSB0YXNrLiBJdAoKVHlwbzogImZyYW1fZV93b3JrIgoKPiBkZS1z dGFnZQo+IHRoZSBTV19TWU5DIHZhbGlkYXRpb24gZnJhbWV3b3JrIGFuZCB0aGUgc3luY19kZWJ1 ZyBpbmZvIGRlYnVnZnMgZmlsZS4KPiAKPiBUaGUgZmlyc3QgMyBwYXRjaGVzIGFyZSBjbGVhbiB1 cCBhbmQgaW1wcm92ZW1lbnRzIGFuZCB0aGUgcmVzdCBpcyBwcmVwYXJhdGlvbgo+IHRvIGRlLXN0 YWdlIGFuZCB0aGVuIGZpbmFsbHkgdGhlIGFjdHVhbCBkZS1zdGFnZS4KCkNvdWxkIHdlIGdldCBz b21lIGtpbmQgb2YgZGVzY3JpcHRpb24gd2hhdCB0aGUgc3luYyBmcmFtZXdvcmsgZG9lcz8KVGhl cmUgYXJlIG5vIHVzZWZ1bCBjb21tZW50cyBpbiAvc3dfc3luYy5jLiBUaGVyZSdzIG5vIERvY3Vt ZW50YXRpb24vCmZpbGVzLiBJIGRvbid0IGtub3cgd2hhdCB0aGlzIGlzIHN1cHBvc2VkIHRvIGRv Li4uCgoJCQkJCQkJCVBhdmVsCgo+IFBsZWFzZSByZXZpZXcsCj4gCj4gR3VzdGF2bwo+IAo+IC0t LQo+IEd1c3Rhdm8gUGFkb3ZhbiAoNyk6Cj4gICBzdGFnaW5nL2FuZHJvaWQ6IG1vdmUgdHJhY2Uv c3luYy5oIHRvIHN5bmNfdHJhY2UuaAo+ICAgc3RhZ2luZy9hbmRyb2lkOiByZW1vdmUgZG9jIGZy b20gc3dfc3luYwo+ICAgc3RhZ2luZy9hbmRyb2lkOiBkaXNwbGF5IHN5bmNfcHQgbmFtZSBvbiBk ZWJ1Z2ZzCj4gICBzdGFnaW5nL2FuZHJvaWQ6IGRvIG5vdCBsZXQgdXNlcnNwYWNlIHRyaWdnZXIg V0FSTl9PTgo+ICAgc3RhZ2luZy9hbmRyb2lkOiBwcmVwYXJlIHN3X3N5bmMgZmlsZXMgZm9yIGRl LXN0YWdpbmcKPiAgIGRtYS1idWYvc3dfc3luYzogZGUtc3RhZ2UgU1dfU1lOQwo+ICAgc3RhZ2lu Zy9hbmRyb2lkOiByZW1vdmUgc3luYyBmcmFtZXdvcmsgVE9ETwo+IAo+ICBkcml2ZXJzL2RtYS1i dWYvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysrKysKPiAgZHJp dmVycy9kbWEtYnVmL01ha2VmaWxlICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCj4g IGRyaXZlcnMve3N0YWdpbmcvYW5kcm9pZCA9PiBkbWEtYnVmfS9zd19zeW5jLmMgICAgIHwgNDYg KysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL3tzdGFnaW5nL2FuZHJvaWQgPT4gZG1h LWJ1Zn0vc3luY19kZWJ1Zy5jICB8ICA3ICsrLS0KPiAgZHJpdmVycy97c3RhZ2luZy9hbmRyb2lk ID0+IGRtYS1idWZ9L3N5bmNfZGVidWcuaCAgfCAyNiArKysrKy0tLS0tLS0KPiAgLi4uL2FuZHJv aWQvdHJhY2Uvc3luYy5oID0+IGRtYS1idWYvc3luY190cmFjZS5ofSAgfCAgNiArLS0KPiAgZHJp dmVycy9zdGFnaW5nL2FuZHJvaWQvS2NvbmZpZyAgICAgICAgICAgICAgICAgICAgfCAxMyAtLS0t LS0KPiAgZHJpdmVycy9zdGFnaW5nL2FuZHJvaWQvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAg fCAgMSAtCj4gIGRyaXZlcnMvc3RhZ2luZy9hbmRyb2lkL1RPRE8gICAgICAgICAgICAgICAgICAg ICAgIHwgIDggLS0tLQo+ICA5IGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDg0IGRl bGV0aW9ucygtKQo+ICByZW5hbWUgZHJpdmVycy97c3RhZ2luZy9hbmRyb2lkID0+IGRtYS1idWZ9 L3N3X3N5bmMuYyAoODQlKQo+ICByZW5hbWUgZHJpdmVycy97c3RhZ2luZy9hbmRyb2lkID0+IGRt YS1idWZ9L3N5bmNfZGVidWcuYyAoOTclKQo+ICByZW5hbWUgZHJpdmVycy97c3RhZ2luZy9hbmRy b2lkID0+IGRtYS1idWZ9L3N5bmNfZGVidWcuaCAoNzIlKQo+ICByZW5hbWUgZHJpdmVycy97c3Rh Z2luZy9hbmRyb2lkL3RyYWNlL3N5bmMuaCA9PiBkbWEtYnVmL3N5bmNfdHJhY2UuaH0gKDg0JSkK PiAKCi0tIAooZW5nbGlzaCkgaHR0cDovL3d3dy5saXZlam91cm5hbC5jb20vfnBhdmVsbWFjaGVr CihjZXNreSwgcGljdHVyZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmkuY3ovfnBhdmVs L3BpY3R1cmUvaG9yc2VzL2Jsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648AbcFZVpK (ORCPT ); Sun, 26 Jun 2016 17:45:10 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46079 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbcFZVpI (ORCPT ); Sun, 26 Jun 2016 17:45:08 -0400 Date: Sun, 26 Jun 2016 23:45:04 +0200 From: Pavel Machek To: Gustavo Padovan Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan Subject: Re: [PATCH 0/7] de-stage SW_SYNC validation frawework Message-ID: <20160626214504.GA21026@amd> References: <1466437993-21573-1-git-send-email-gustavo@padovan.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466437993-21573-1-git-send-email-gustavo@padovan.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It Typo: "fram_e_work" > de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The first 3 patches are clean up and improvements and the rest is preparation > to de-stage and then finally the actual de-stage. Could we get some kind of description what the sync framework does? There are no useful comments in /sw_sync.c. There's no Documentation/ files. I don't know what this is supposed to do... Pavel > Please review, > > Gustavo > > --- > Gustavo Padovan (7): > staging/android: move trace/sync.h to sync_trace.h > staging/android: remove doc from sw_sync > staging/android: display sync_pt name on debugfs > staging/android: do not let userspace trigger WARN_ON > staging/android: prepare sw_sync files for de-staging > dma-buf/sw_sync: de-stage SW_SYNC > staging/android: remove sync framework TODO > > drivers/dma-buf/Kconfig | 14 +++++++ > drivers/dma-buf/Makefile | 1 + > drivers/{staging/android => dma-buf}/sw_sync.c | 46 +++------------------- > drivers/{staging/android => dma-buf}/sync_debug.c | 7 ++-- > drivers/{staging/android => dma-buf}/sync_debug.h | 26 +++++------- > .../android/trace/sync.h => dma-buf/sync_trace.h} | 6 +-- > drivers/staging/android/Kconfig | 13 ------ > drivers/staging/android/Makefile | 1 - > drivers/staging/android/TODO | 8 ---- > 9 files changed, 38 insertions(+), 84 deletions(-) > rename drivers/{staging/android => dma-buf}/sw_sync.c (84%) > rename drivers/{staging/android => dma-buf}/sync_debug.c (97%) > rename drivers/{staging/android => dma-buf}/sync_debug.h (72%) > rename drivers/{staging/android/trace/sync.h => dma-buf/sync_trace.h} (84%) > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html