From: Joerg Roedel <joro@8bytes.org>
To: Jan Niehusmann <jan@gondor.com>
Cc: Omer Peleg <omer@cs.technion.ac.il>,
David.Woodhouse@intel.com, intel-gfx@lists.freedesktop.org,
iommu@lists.linux-foundation.org,
Adam Morrison <mad@cs.technion.ac.il>
Subject: Re: [PATCH v2] iommu/vt-d: fix overflow of iommu->domains array
Date: Mon, 27 Jun 2016 13:23:32 +0200 [thread overview]
Message-ID: <20160627112332.GB13539@8bytes.org> (raw)
In-Reply-To: <20160606122010.GA3048@x61s.reliablesolutions.de>
On Mon, Jun 06, 2016 at 02:20:11PM +0200, Jan Niehusmann wrote:
> The valid range of 'did' in get_iommu_domain(*iommu, did)
> is 0..cap_ndoms(iommu->cap), so don't exceed that
> range in free_all_cpu_cached_iovas().
>
> The user-visible impact of the out-of-bounds access is the machine
> hanging on suspend-to-ram. It is, in fact, a kernel panic, but due
> to already suspended devices, that's often not visible to the user.
>
> Fixes: 22e2f9fa63b0 ("iommu/vt-d: Use per-cpu IOVA caching")
> Signed-off-by: Jan Niehusmann <jan@gondor.com>
> Tested-By: Marius Vlad <marius.c.vlad@intel.com>
Queued to iommu/fixes branch, thanks Jan.
Joerg
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-06-27 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 21:02 iommu/vt-d: Use per-cpu IOVA caching, suspend-to-ram causes machine hang Adam Morrison
2016-06-06 10:32 ` Marius Vlad
2016-06-06 12:20 ` [PATCH v2] iommu/vt-d: fix overflow of iommu->domains array Jan Niehusmann
2016-06-27 11:23 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627112332.GB13539@8bytes.org \
--to=joro@8bytes.org \
--cc=David.Woodhouse@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jan@gondor.com \
--cc=mad@cs.technion.ac.il \
--cc=omer@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.