diff for duplicates of <20160627124432.GI29249@piout.net> diff --git a/a/1.txt b/N1/1.txt index 2bde4af..1ec3422 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,24 +4,22 @@ On 27/06/2016 at 14:50:49 +0300, Sergei Ianovich wrote : > > But I would like to access it with using three wires connected to > > GPIO > > lines. -> >=20 +> > > > This adds abstraction layer for DS1302 register access in order to -> > prepare to support for using GPIO lines.=C2=A0=C2=A0This enables to sha= -re +> > prepare to support for using GPIO lines. This enables to share > > common > > code between SPI driver and GPIO driver. ->=20 +> > I don't think this is the right way. DS-1302 is an SPI device, not a > GPIO one. It can be connected to a hardware SPI controller or a > software one (on top of GPIO or memory). ->=20 +> > Your patch re-adds Microwire SPI control logic to RTC subsystem, which > was cleared by my rewrite of drivers/rtc/rtc-ds1302.c. The logic is -> already present in=C2=A0bitbang_txrx_be_cpha0_lsb() in=C2=A0drivers/spi/s= -pi- +> already present in bitbang_txrx_be_cpha0_lsb() in drivers/spi/spi- > lp8841-rtc.c. ->=20 -> I still think you need to implement=C2=A0spi-gpio-3wire with LSB-first +> +> I still think you need to implement spi-gpio-3wire with LSB-first > support in SPI subsystem instead. It wasn't done when I was adding > LP8841 support, because LP8841 was the only use case of Microwire SPI > control logic. If you add it, drivers/spi/spi-lp8841-rtc.c can be @@ -39,19 +37,17 @@ microwire-gpio driver. Maybe in the SPI subsystem? How do yo currently select microwire mode for PX270? ---=20 +-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ---=20 +-- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ----=20 -You received this message because you are subscribed to the Google Groups "= -rtc-linux" group. -To unsubscribe from this group and stop receiving emails from it, send an e= -mail to rtc-linux+unsubscribe@googlegroups.com. +--- +You received this message because you are subscribed to the Google Groups "rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index fca88a6..440cecd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,15 @@ "ref\01467026362-29446-1-git-send-email-akinobu.mita@gmail.com\0" "ref\01467026362-29446-2-git-send-email-akinobu.mita@gmail.com\0" "ref\01467028249.3182.11.camel@gmail.com\0" - "From\0Alexandre Belloni <alexandre.belloni@free-electrons.com>\0" - "Subject\0[rtc-linux] Re: [PATCH v2 1/2] rtc: ds1302: add register access abstraction layer\0" + "ref\01467028249.3182.11.camel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" + "From\0Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>\0" + "Subject\0Re: [PATCH v2 1/2] rtc: ds1302: add register access abstraction layer\0" "Date\0Mon, 27 Jun 2016 14:44:32 +0200\0" - "To\0Sergei Ianovich <ynvich@gmail.com>\0" - "Cc\0Akinobu Mita <akinobu.mita@gmail.com>" - rtc-linux@googlegroups.com - devicetree@vger.kernel.org - " Alessandro Zummo <a.zummo@towertech.it>\0" + "To\0Sergei Ianovich <ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Cc\0Akinobu Mita <akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" + rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " Alessandro Zummo <a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>\0" "\00:1\0" "b\0" "On 27/06/2016 at 14:50:49 +0300, Sergei Ianovich wrote :\n" @@ -17,24 +18,22 @@ "> > But I would like to access it with using three wires connected to\n" "> > GPIO\n" "> > lines.\n" - "> >=20\n" + "> > \n" "> > This adds abstraction layer for DS1302 register access in order to\n" - "> > prepare to support for using GPIO lines.=C2=A0=C2=A0This enables to sha=\n" - "re\n" + "> > prepare to support for using GPIO lines.\302\240\302\240This enables to share\n" "> > common\n" "> > code between SPI driver and GPIO driver.\n" - ">=20\n" + "> \n" "> I don't think this is the right way. DS-1302 is an SPI device, not a\n" "> GPIO one. It can be connected to a hardware SPI controller or a\n" "> software one (on top of GPIO or memory).\n" - ">=20\n" + "> \n" "> Your patch re-adds Microwire SPI control logic to RTC subsystem, which\n" "> was cleared by my rewrite of drivers/rtc/rtc-ds1302.c. The logic is\n" - "> already present in=C2=A0bitbang_txrx_be_cpha0_lsb() in=C2=A0drivers/spi/s=\n" - "pi-\n" + "> already present in\302\240bitbang_txrx_be_cpha0_lsb() in\302\240drivers/spi/spi-\n" "> lp8841-rtc.c.\n" - ">=20\n" - "> I still think you need to implement=C2=A0spi-gpio-3wire with LSB-first\n" + "> \n" + "> I still think you need to implement\302\240spi-gpio-3wire with LSB-first\n" "> support in SPI subsystem instead. It wasn't done when I was adding\n" "> LP8841 support, because LP8841 was the only use case of Microwire SPI\n" "> control logic. If you add it, drivers/spi/spi-lp8841-rtc.c can be\n" @@ -52,21 +51,19 @@ "\n" "How do yo currently select microwire mode for PX270?\n" "\n" - "--=20\n" + "-- \n" "Alexandre Belloni, Free Electrons\n" "Embedded Linux, Kernel and Android engineering\n" "http://free-electrons.com\n" "\n" - "--=20\n" + "-- \n" "You received this message because you are subscribed to \"rtc-linux\".\n" "Membership options at http://groups.google.com/group/rtc-linux .\n" "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" "before submitting a driver.\n" - "---=20\n" - "You received this message because you are subscribed to the Google Groups \"=\n" - "rtc-linux\" group.\n" - "To unsubscribe from this group and stop receiving emails from it, send an e=\n" - "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + "--- \n" + "You received this message because you are subscribed to the Google Groups \"rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org\n" For more options, visit https://groups.google.com/d/optout. -1d50a7922e41501c1a893ce5f1b325de2376549d2958be6dc85f69b513dab45f +1c7c35f781bfee38ad28fb10700b689ad703322663775290213fc199ac99ced1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.