From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: IB/hfi1: add driver files
Date: Mon, 27 Jun 2016 16:19:29 +0300 [thread overview]
Message-ID: <20160627131928.GA28678@mwanda> (raw)
Hello Mike Marciniszyn,
The patch 7724105686e7: "IB/hfi1: add driver files" from Jul 30,
2015, leads to the following static checker warning:
drivers/infiniband/hw/hfi1/user_sdma.c:1438 set_txreq_header_ahg()
warn: mask and shift to zero
drivers/infiniband/hw/hfi1/user_sdma.c
1436 /* Clear KDETH.SH on last packet */
1437 if (unlikely(tx->flags & TXREQ_FLAGS_REQ_LAST_PKT)) {
1438 val |= cpu_to_le16(KDETH_GET(hdr->kdeth.ver_tid_offset,
1439 INTR) >> 16);
The >> 16 should probably be deleted. My guess is that it's left over
from an open coded byte swap?
1440 val &= cpu_to_le16(~(1U << 13));
1441 AHG_HEADER_SET(req->ahg, diff, 7, 16, 14, val);
1442 } else {
1443 AHG_HEADER_SET(req->ahg, diff, 7, 16, 12, val);
1444 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2016-06-27 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 13:19 Dan Carpenter [this message]
2016-07-13 16:27 ` IB/hfi1: add driver files Marciniszyn, Mike
-- strict thread matches above, loose matches on Subject: below --
2015-09-16 7:14 Dan Carpenter
2015-09-16 7:13 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627131928.GA28678@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.