From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbcF0RfO (ORCPT ); Mon, 27 Jun 2016 13:35:14 -0400 Received: from mail.kernel.org ([198.145.29.136]:59546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbcF0RfL (ORCPT ); Mon, 27 Jun 2016 13:35:11 -0400 Date: Mon, 27 Jun 2016 14:35:05 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: linux-kernel@vger.kernel.org, anton@ozlabs.org, mpe@ellerman.id.au, ananth@in.ibm.com, dja@axtens.net Subject: Re: [RFC 1/6] perf: Remove unused hist_entry__annotate function Message-ID: <20160627173505.GB27027@kernel.org> References: <1466769240-12376-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1466769240-12376-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466769240-12376-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Jun 24, 2016 at 05:23:55PM +0530, Ravi Bangoria escreveu: > hist_entry__annotate looks part of API but I don't find any caller > of this function. Removing it. Thanks, applied. - Arnaldo > Signed-off-by: Ravi Bangoria > --- > tools/perf/util/annotate.c | 5 ----- > tools/perf/util/annotate.h | 2 -- > 2 files changed, 7 deletions(-) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 7e5a1e8..b2c7ae4 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, > return 0; > } > > -int hist_entry__annotate(struct hist_entry *he, size_t privsize) > -{ > - return symbol__annotate(he->ms.sym, he->ms.map, privsize); > -} > - > bool ui__has_annotation(void) > { > return use_browser == 1 && perf_hpp_list.sym; > diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h > index 9241f8c..82f3781 100644 > --- a/tools/perf/util/annotate.h > +++ b/tools/perf/util/annotate.h > @@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym); > > int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize); > > -int hist_entry__annotate(struct hist_entry *he, size_t privsize); > - > int symbol__annotate_init(struct map *map, struct symbol *sym); > int symbol__annotate_printf(struct symbol *sym, struct map *map, > struct perf_evsel *evsel, bool full_paths, > -- > 2.5.5