From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: qede: Add support for coalescing config read/update.
Date: Mon, 27 Jun 2016 19:42:10 +0000 [thread overview]
Message-ID: <20160627194210.GA30526@mwanda> (raw)
Hello Sudarsana Reddy Kalluru,
The patch d552fa84cb35: "qede: Add support for coalescing config
read/update." from Jun 21, 2016, leads to the following static
checker warning:
drivers/net/ethernet/qlogic/qede/qede_ethtool.c:435 qede_get_coalesce()
warn: passing casted pointer '&coal->rx_coalesce_usecs' to 'edev->ops->common->get_coalesce()' 32 vs 16.
drivers/net/ethernet/qlogic/qede/qede_ethtool.c
429 static int qede_get_coalesce(struct net_device *dev,
430 struct ethtool_coalesce *coal)
431 {
432 struct qede_dev *edev = netdev_priv(dev);
433
434 memset(coal, 0, sizeof(struct ethtool_coalesce));
435 edev->ops->common->get_coalesce(edev->cdev,
436 (u16 *)&coal->rx_coalesce_usecs,
437 (u16 *)&coal->tx_coalesce_usecs);
This won't work on big endian systems. Fix it so the function takes a
u32 or make ->rx_coalesce_usecs a u16.
438
439 return 0;
440 }
regards,
dan carpenter
next reply other threads:[~2016-06-27 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 19:42 Dan Carpenter [this message]
2016-06-28 4:41 ` qede: Add support for coalescing config read/update Sudarsana Kalluru
2016-06-28 7:17 ` walter harms
2016-06-28 7:26 ` Yuval Mintz
2016-06-28 9:05 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627194210.GA30526@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.