From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/virtio-user: fix O_CLOEXEC undeclared
	error
Date: Tue, 28 Jun 2016 17:02:54 +0800
Message-ID: <20160628090254.GZ23111@yliu-dev.sh.intel.com>
References: <1466948986-12255-1-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, huawei.xie@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 613EE37B6
 for <dev@dpdk.org>; Tue, 28 Jun 2016 11:02:43 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1466948986-12255-1-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Jun 26, 2016 at 01:49:46PM +0000, Jianfeng Tan wrote:
> On some older systems, such as SUSE 11, the compiling error shows
> as:
>    .../dpdk/drivers/net/virtio/virtio_user/virtio_user_dev.c:67:22:
>          error: =E2=80=98O_CLOEXEC=E2=80=99 undeclared (first use in th=
is function)
>=20
> The fix is to declare _GNU_SOURCE macro before include fcntl.h.

I think you need give a reason how that error comes and why this
would fix the error.

And if you look at the git history, you might want to define this
macro in Makefile. See commit e49680a87e06 ("mk: compilation fixes").

Last, don't forgot to run ./scripts/check-git-log.sh against your patch.

	--yliu