Re: [PATCH RESEND] spi: spidev: Allow matching DT compatible strings from ACPI

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Tue, Jun 28, 2016 at 05:35:28PM +0300, Mika Westerberg wrote:
> On Tue, Jun 28, 2016 at 12:47:42PM +0100, Mark Brown wrote:

> > The big thing I need to check out here is if this breaks the check for
> > directly listing spidev in DT so we end up with the same abstraction
> > failures that plague DT since people refuse to describe their hardware.

> You are talking about this check, right?

>         if (spi->dev.of_node && !of_match_device(spidev_dt_ids, &spi->dev)) {
>                 dev_err(&spi->dev, "buggy DT: spidev listed directly in DT\n");
>                 WARN_ON(spi->dev.of_node &&
>                         !of_match_device(spidev_dt_ids, &spi->dev));
>         } 

> As far as I can tell it should work, with the patch applied, just as it worked
> before. For ACPI there is no possibility to list the node directly in ASL code
> as we always require DT compatible string in _DSD.

Yes, but does of_node get set and does of_match_device() DTRT if it's a
DT into ACPI device?

> In other words we never match using name of the node.

If that's the case then it's definitely broken - we either always warn
or never warn, neither is good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]