From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device
Date: Tue, 28 Jun 2016 17:11:26 -0700 [thread overview]
Message-ID: <20160628171126.5da73f41@xeon-e3> (raw)
In-Reply-To: <08825943-ee97-c769-e70a-f6dcc3f49493@cumulusnetworks.com>
On Tue, 28 Jun 2016 11:40:40 -0600
David Ahern <dsa@cumulusnetworks.com> wrote:
> On 6/27/16 3:13 PM, Stephen Hemminger wrote:
> > On Mon, 27 Jun 2016 11:34:25 -0700
> > David Ahern <dsa@cumulusnetworks.com> wrote:
> >
> >> + case SSF_DEVCOND:
> >> + {
> >> + struct aafilter *a = (void *)f->pred;
> >
> > I don't like the wandering bracket left, but all the code has that.
> > After this will change it to:
> > case SSF_DEVCOND: {
> > struct aafilter *a = f->pred;
> > ...
> >
>
> meaning you'll take the patches as is since they follow current
> formatting and you will apply a patch to fix the indentation in that
> run_ssfilter? They have not shown up in your repo so want to make sure I
> understand the intent.
They all got applied today
prev parent reply other threads:[~2016-06-29 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 18:34 [PATCH v2 iproute2 0/3] ss: Add support to filter by device David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 1/3] ss: Refactor inet_show_sock David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 2/3] ss: Allow ssfilter_bytecompile to return 0 David Ahern
2016-06-27 18:34 ` [PATCH v2 iproute2 3/3] ss: Add support to filter on device David Ahern
2016-06-27 21:13 ` Stephen Hemminger
2016-06-28 17:40 ` David Ahern
2016-06-29 0:11 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628171126.5da73f41@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.