From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/082: rename _filter_project_quota to a avoid function name conflict
Date: Wed, 29 Jun 2016 16:11:09 +1000 [thread overview]
Message-ID: <20160629061109.GS27480@dastard> (raw)
In-Reply-To: <1467163987-11242-1-git-send-email-tytso@mit.edu>
On Tue, Jun 28, 2016 at 09:33:07PM -0400, Theodore Ts'o wrote:
> Commit 8469a8c1: "xfs/133-4: filter redundant projid 0 quota report
> info out" added _filter_project_quota to common/filter, and this
> conflicted with a _filter_project_quota function in generic/082. So
> rename the function in generic/082 to avoid the conflict.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> tests/generic/082 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/generic/082 b/tests/generic/082
> index a727c10..fa61ba9 100755
> --- a/tests/generic/082
> +++ b/tests/generic/082
> @@ -36,9 +36,9 @@ _cleanup()
> rm -f $tmp.*
> }
>
> -_filter_project_quota()
> +_filter_project_quota_line()
> {
> - grep -v "^project quota on"
> + grep -v "^project quota on"
> }
Functions starting with "_" denote common scope functions (i.e.
from externally sourced files), not local test functions. Just
remove the "_" prefix here....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-06-29 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 1:33 [PATCH] generic/082: rename _filter_project_quota to a avoid function name conflict Theodore Ts'o
2016-06-29 6:11 ` Dave Chinner [this message]
2016-06-29 13:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629061109.GS27480@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.