From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
konstantin.ananyev@intel.com, dev@dpdk.org,
helin.zhang@intel.com, amint@icsi.berkeley.edu
Subject: Re: [PATCH] ixgbe: fix compilation when offload flags disabled
Date: Wed, 29 Jun 2016 11:15:52 +0100 [thread overview]
Message-ID: <20160629101552.GE4720@bricha3-MOBL3> (raw)
In-Reply-To: <1569745.6sBGvsO00c@xps13>
On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote:
> 2016-06-27 17:44, Olivier Matz:
> > The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n
> > because the macro has not the proper number of parameters.
>
> We really need to understand why this build option is needed.
> Target: zero build option.
Agreed. However, we are where we are right now, and this build option is there.
Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since
the code in question has actually moved on that branch.
Out of interest, can you perhaps also give a little more detail on how to
reproduce the issue, as turning off the setting fails to show up a build
problem for me with either gcc or clang, at -O3 or -O0.
/Bruce
next prev parent reply other threads:[~2016-06-29 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 15:44 [PATCH] ixgbe: fix compilation when offload flags disabled Olivier Matz
2016-06-27 17:05 ` Thomas Monjalon
2016-06-29 10:15 ` Bruce Richardson [this message]
2016-06-29 11:35 ` Olivier MATZ
2016-06-29 12:30 ` Bruce Richardson
2016-07-01 8:02 ` [PATCH v2] net/ixgbe: " Olivier Matz
2016-07-01 9:02 ` Ananyev, Konstantin
2016-07-05 9:11 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629101552.GE4720@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=amint@icsi.berkeley.edu \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.