From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: andrew zamansky
<andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
azamansk-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org,
Dan.Morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org,
stimpy1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/2] add irq validity check in tpm_i2c_nuvoton driver
Date: Wed, 29 Jun 2016 12:20:47 -0600 [thread overview]
Message-ID: <20160629182047.GA17031@obsidianresearch.com> (raw)
In-Reply-To: <1467194329-5543-3-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
On Wed, Jun 29, 2016 at 12:58:49PM +0300, andrew zamansky wrote:
> if irq==0 (actualy invalid value) then error is printed to dmesg after
> trying to register to 0 interrupt
Missing Signed-off-by line.
And this patch should have:
Fixes: 570a36097f30 ("tpm: drop 'irq' from struct tpm_vendor_specific")
There is also no need to re-sent the patch that is being fixed.
> - chip->flags |= TPM_CHIP_FLAG_IRQ;
> + if(chip->flags)
> + chip->flags |= TPM_CHIP_FLAG_IRQ;
> +
Don't forget to run checkpatch
Jason
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
prev parent reply other threads:[~2016-06-29 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 9:58 [PATCH 0/2] add irq validity check in tpm_i2c_nuvoton driver andrew zamansky
[not found] ` <1467194329-5543-1-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
2016-06-29 9:58 ` [PATCH 1/2] tpm: drop 'irq' from struct tpm_vendor_specific andrew zamansky
2016-06-29 9:58 ` [PATCH 2/2] add irq validity check in tpm_i2c_nuvoton driver andrew zamansky
[not found] ` <1467194329-5543-3-git-send-email-andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org>
2016-06-29 14:03 ` Jarkko Sakkinen
[not found] ` <20160629140339.GA4589-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-01 8:39 ` Jarkko Sakkinen
2016-07-12 17:33 ` Jason Gunthorpe
[not found] ` <20160712173326.GA9286-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-13 12:04 ` Jarkko Sakkinen
[not found] ` <20160713120401.GA4387-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-18 17:50 ` Jarkko Sakkinen
[not found] ` <20160718175053.GA7213-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-19 14:35 ` Jarkko Sakkinen
2016-06-29 18:20 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629182047.GA17031@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Dan.Morav-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=andrew.zamansky-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=azamansk-KrzQf0k3Iz9BDgjK7y7TUQ@public.gmane.org \
--cc=gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=stimpy1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.