From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1041447377740887534==" MIME-Version: 1.0 From: Oleg Nesterov To: lkp@lists.01.org Subject: Re: [PATCH] kthread: to_live_kthread() needs try_get_task_stack() Date: Wed, 29 Jun 2016 20:44:27 +0200 Message-ID: <20160629184427.GA3928@redhat.com> In-Reply-To: <201606300245.vASQFf80%fengguang.wu@intel.com> List-Id: --===============1041447377740887534== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 06/30, kbuild test robot wrote: > > Hi, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.7-rc5 next-20160629] > [if your patch is applied to the wrong git tree, please drop us a note to= help improve the system] Yes, please ignore this, the patch is based on Andy's x86/vmap_stack tree. > url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/kthread-to= _live_kthread-needs-try_get_task_stack/20160630-020824 > config: i386-tinyconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 > reproduce: > # save the attached .config to linux build tree > make ARCH=3Di386 = > = > All errors (new ones prefixed by >>): > = > kernel/kthread.c: In function 'to_live_kthread': > >> kernel/kthread.c:67:23: error: implicit declaration of function 'try_g= et_task_stack' [-Werror=3Dimplicit-function-declaration] > if (likely(vfork) && try_get_task_stack(k)) > ^~~~~~~~~~~~~~~~~~ > kernel/kthread.c: In function 'kthread_unpark': > >> kernel/kthread.c:430:3: error: implicit declaration of function 'put_t= ask_stack' [-Werror=3Dimplicit-function-declaration] > put_task_stack(k); > ^~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > = > vim +/try_get_task_stack +67 kernel/kthread.c > = > 61 return __to_kthread(k->vfork_done); > 62 } > 63 = > 64 static struct kthread *to_live_kthread(struct task_struct *k) > 65 { > 66 struct completion *vfork =3D ACCESS_ONCE(k->vfork_done); > > 67 if (likely(vfork) && try_get_task_stack(k)) > 68 return __to_kthread(vfork); > 69 return NULL; > 70 } > = > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion --===============1041447377740887534==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbcF2Sny (ORCPT ); Wed, 29 Jun 2016 14:43:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47168 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbcF2Snx (ORCPT ); Wed, 29 Jun 2016 14:43:53 -0400 Date: Wed, 29 Jun 2016 20:44:27 +0200 From: Oleg Nesterov To: kbuild test robot Cc: kbuild-all@01.org, Andy Lutomirski , Andy Lutomirski , Linus Torvalds , Peter Zijlstra , Tejun Heo , LKP , LKML , kernel test robot Subject: Re: [PATCH] kthread: to_live_kthread() needs try_get_task_stack() Message-ID: <20160629184427.GA3928@redhat.com> References: <20160629180357.GA7178@redhat.com> <201606300245.vASQFf80%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201606300245.vASQFf80%fengguang.wu@intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 29 Jun 2016 18:43:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30, kbuild test robot wrote: > > Hi, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.7-rc5 next-20160629] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] Yes, please ignore this, the patch is based on Andy's x86/vmap_stack tree. > url: https://github.com/0day-ci/linux/commits/Oleg-Nesterov/kthread-to_live_kthread-needs-try_get_task_stack/20160630-020824 > config: i386-tinyconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones prefixed by >>): > > kernel/kthread.c: In function 'to_live_kthread': > >> kernel/kthread.c:67:23: error: implicit declaration of function 'try_get_task_stack' [-Werror=implicit-function-declaration] > if (likely(vfork) && try_get_task_stack(k)) > ^~~~~~~~~~~~~~~~~~ > kernel/kthread.c: In function 'kthread_unpark': > >> kernel/kthread.c:430:3: error: implicit declaration of function 'put_task_stack' [-Werror=implicit-function-declaration] > put_task_stack(k); > ^~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > vim +/try_get_task_stack +67 kernel/kthread.c > > 61 return __to_kthread(k->vfork_done); > 62 } > 63 > 64 static struct kthread *to_live_kthread(struct task_struct *k) > 65 { > 66 struct completion *vfork = ACCESS_ONCE(k->vfork_done); > > 67 if (likely(vfork) && try_get_task_stack(k)) > 68 return __to_kthread(vfork); > 69 return NULL; > 70 } > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation