From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f197.google.com (mail-qt0-f197.google.com [209.85.216.197]) by kanga.kvack.org (Postfix) with ESMTP id 1BF1B828E1 for ; Wed, 29 Jun 2016 15:22:38 -0400 (EDT) Received: by mail-qt0-f197.google.com with SMTP id f89so130966713qtd.1 for ; Wed, 29 Jun 2016 12:22:38 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id v129si4061980qkc.105.2016.06.29.12.22.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2016 12:22:37 -0700 (PDT) Date: Wed, 29 Jun 2016 21:22:33 +0200 From: Oleg Nesterov Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Message-ID: <20160629192232.GA19097@redhat.com> References: <1467201562-6709-1-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467201562-6709-1-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Andrew Morton , Tetsuo Handa , Vladimir Davydov , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko On 06/29, Michal Hocko wrote: > > But it seems that further changes I am > planning in this area will benefit from stable task->mm in this path Oh, so I hope you will cleanup this later, > Just pull the task->mm != > NULL check inside the function. OK, but this means it will always return false if the task is a zombie leader. I am not really arguing and this is not that bad, but this doesn't look nice and imo asks for cleanup. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbcF2TWi (ORCPT ); Wed, 29 Jun 2016 15:22:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35894 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbcF2TWh (ORCPT ); Wed, 29 Jun 2016 15:22:37 -0400 Date: Wed, 29 Jun 2016 21:22:33 +0200 From: Oleg Nesterov To: Michal Hocko Cc: Andrew Morton , Tetsuo Handa , Vladimir Davydov , David Rientjes , linux-mm@kvack.org, LKML , Michal Hocko Subject: Re: [PATCH] mmotm: mm-oom-fortify-task_will_free_mem-fix Message-ID: <20160629192232.GA19097@redhat.com> References: <1467201562-6709-1-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467201562-6709-1-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 29 Jun 2016 19:22:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29, Michal Hocko wrote: > > But it seems that further changes I am > planning in this area will benefit from stable task->mm in this path Oh, so I hope you will cleanup this later, > Just pull the task->mm != > NULL check inside the function. OK, but this means it will always return false if the task is a zombie leader. I am not really arguing and this is not that bad, but this doesn't look nice and imo asks for cleanup. Oleg.