From: Sebastian Reichel <sre@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: qcom-smbb: add extcon dependency
Date: Wed, 29 Jun 2016 23:09:58 +0200 [thread overview]
Message-ID: <20160629210958.GB15422@earth> (raw)
In-Reply-To: <57740F1A.5040007@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Hi,
On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> >> Building the smbb driver without extcon results in a link failure:
> >>
> >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> >> drivers/power/built-in.o: In function `smbb_charger_probe':
> >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> >>
> >> This adds a Kconfig dependency.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
>
> extcon use was only recently introduced so this should be
>
> Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> detection")
Right, I didn't notice the Fixes line is wrong. Since I will have to
rebase now, I will just squash this into 0b7fe26ae602.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-29 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:30 [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann
2016-06-29 14:38 ` Sebastian Reichel
2016-06-29 18:10 ` Stephen Boyd
2016-06-29 21:09 ` Sebastian Reichel [this message]
2016-06-29 21:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629210958.GB15422@earth \
--to=sre@kernel.org \
--cc=arnd@arndb.de \
--cc=courtney.cavin@sonymobile.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.