From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 30 Jun 2016 11:26:50 +0200 From: Pablo Neira Ayuso Message-ID: <20160630092650.GA2107@salvia> References: <20160624085752.GB1939@salvia> <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com> <20160628.090112.1438085992622018555.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160628.090112.1438085992622018555.davem@davemloft.net> Subject: Re: [Bridge] [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, joe@perches.com, kaber@trash.net On Tue, Jun 28, 2016 at 09:01:12AM -0400, David Miller wrote: > From: Joe Perches > Date: Fri, 24 Jun 2016 11:32:26 -0700 > > > There are code duplications of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > > > Signed-off-by: Joe Perches > > Pablo feel free to take this: > > Acked-by: David S. Miller Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked Date: Thu, 30 Jun 2016 11:26:50 +0200 Message-ID: <20160630092650.GA2107@salvia> References: <20160624085752.GB1939@salvia> <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com> <20160628.090112.1438085992622018555.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, joe@perches.com, kaber@trash.net To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20160628.090112.1438085992622018555.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netfilter-devel.vger.kernel.org On Tue, Jun 28, 2016 at 09:01:12AM -0400, David Miller wrote: > From: Joe Perches > Date: Fri, 24 Jun 2016 11:32:26 -0700 > > > There are code duplications of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > > > Signed-off-by: Joe Perches > > Pablo feel free to take this: > > Acked-by: David S. Miller Applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbcF3J2u (ORCPT ); Thu, 30 Jun 2016 05:28:50 -0400 Received: from mail.us.es ([193.147.175.20]:54097 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929AbcF3J2r (ORCPT ); Thu, 30 Jun 2016 05:28:47 -0400 Date: Thu, 30 Jun 2016 11:26:50 +0200 From: Pablo Neira Ayuso To: David Miller Cc: joe@perches.com, kaber@trash.net, kadlec@blackhole.kfki.hu, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked Message-ID: <20160630092650.GA2107@salvia> References: <20160624085752.GB1939@salvia> <3dcddfef3b9ac0eceb2869d9e95ae857b509fabe.1466793022.git.joe@perches.com> <20160628.090112.1438085992622018555.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160628.090112.1438085992622018555.davem@davemloft.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2016 at 09:01:12AM -0400, David Miller wrote: > From: Joe Perches > Date: Fri, 24 Jun 2016 11:32:26 -0700 > > > There are code duplications of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscellanea: > > > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > > > Signed-off-by: Joe Perches > > Pablo feel free to take this: > > Acked-by: David S. Miller Applied, thanks!