From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com
Subject: Re: [PATCH v2] mempool: rename functions with confusing names
Date: Thu, 30 Jun 2016 13:08:53 +0100 [thread overview]
Message-ID: <20160630120852.GA15232@bricha3-MOBL3> (raw)
In-Reply-To: <1585831.LcblvschXd@xps13>
On Thu, Jun 30, 2016 at 02:00:16PM +0200, Thomas Monjalon wrote:
> 2016-06-29 17:27, Bruce Richardson:
> > Fix this by introducing two new functions to replace the old ones,
> > * rte_mempool_avail_count to replace rte_mempool_count
> > * rte_mempool_in_use_count to replace rte_mempool_free_count
>
> This patch needs to be rebased please.
>
> > --- a/lib/librte_mempool/rte_mempool_version.map
> > +++ b/lib/librte_mempool/rte_mempool_version.map
> > @@ -32,5 +32,6 @@ DPDK_16.07 {
> > rte_mempool_populate_virt;
> > rte_mempool_register_ops;
> > rte_mempool_set_ops_byname;
> > + rte_mempool_avail_count;
>
> The "in_use_count" function is missing.
> Please keep alphabetical order.
We need a search-replace function that is smart enough to reorder things for us!
next prev parent reply other threads:[~2016-06-30 12:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 13:55 [PATCH] mempool: rename functions with confusing names Bruce Richardson
2016-06-29 15:55 ` Thomas Monjalon
2016-06-29 16:00 ` Bruce Richardson
2016-06-29 16:02 ` Wiles, Keith
2016-06-29 16:05 ` Olivier MATZ
2016-06-29 16:19 ` Richardson, Bruce
2016-06-29 16:27 ` [PATCH v2] " Bruce Richardson
2016-06-29 16:30 ` Bruce Richardson
2016-06-30 12:00 ` Thomas Monjalon
2016-06-30 12:02 ` Panu Matilainen
2016-06-30 12:09 ` Bruce Richardson
2016-06-30 12:08 ` Bruce Richardson [this message]
2016-06-30 12:49 ` [PATCH v3] " Bruce Richardson
2016-06-30 20:05 ` Thomas Monjalon
2016-07-01 8:57 ` Olivier MATZ
2016-07-01 10:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630120852.GA15232@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.