From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH] jbd2: make journal y2038 safe Date: Thu, 30 Jun 2016 11:49:38 -0400 Message-ID: <20160630154938.GG2028@thunk.org> References: <20160617153916.444842-1-arnd@arndb.de> <20160619155347.GB2734@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: y2038@lists.linaro.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Jan Kara To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20160619155347.GB2734@quack2.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" List-Id: linux-ext4.vger.kernel.org T24gU3VuLCBKdW4gMTksIDIwMTYgYXQgMDU6NTM6NDdQTSArMDIwMCwgSmFuIEthcmEgd3JvdGU6 Cj4gT24gRnJpIDE3LTA2LTE2IDE3OjM5OjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ID4gVGhl IGpiZDIgam91cm5hbCBzdG9yZXMgdGhlIGNvbW1pdCB0aW1lIGluIDY0LWJpdCBzZWNvbmRzIGFu ZCAzMi1iaXQKPiA+IG5hbm9zZWNvbmRzLCB3aGljaCBhdm9pZHMgYW4gb3ZlcmZsb3cgaW4gMjAz OCwgYnV0IGl0IGdldHMgdGhlIG51bWJlcnMKPiA+IGZyb20gY3VycmVudF9rZXJuZWxfdGltZSgp LCB3aGljaCB1c2VzICdsb25nJyBzZWNvbmRzIG9uIDMyLWJpdAo+ID4gYXJjaGl0ZWN0dXJlcy4K PiA+IAo+ID4gVGhpcyBzaW1wbHkgY2hhbmdlcyB0aGUgY29kZSB0byBjYWxsIGN1cnJlbnRfa2Vy bmVsX3RpbWU2NCgpIHNvCj4gPiB3ZSB1c2UgNjQtYml0IHNlY29uZHMgY29uc2lzdGVudGx5Lgo+ ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+IAo+ IFRoZSBwYXRjaCBsb29rcyBnb29kLiBZb3UgY2FuIGFkZDoKPiAKPiBSZXZpZXdlZC1ieTogSmFu IEthcmEgPGphY2tAc3VzZS5jej4KCkFwcGxpZWQsIHRoYW5rcy4KCgkJCQkJLSBUZWQKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWTIwMzggbWFpbGluZyBs aXN0ClkyMDM4QGxpc3RzLmxpbmFyby5vcmcKaHR0cHM6Ly9saXN0cy5saW5hcm8ub3JnL21haWxt YW4vbGlzdGluZm8veTIwMzgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbcF3PwI (ORCPT ); Thu, 30 Jun 2016 11:52:08 -0400 Received: from imap.thunk.org ([74.207.234.97]:40552 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbcF3PwE (ORCPT ); Thu, 30 Jun 2016 11:52:04 -0400 Date: Thu, 30 Jun 2016 11:49:38 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: Arnd Bergmann , Jan Kara , y2038@lists.linaro.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] jbd2: make journal y2038 safe Message-ID: <20160630154938.GG2028@thunk.org> Mail-Followup-To: Theodore Ts'o , Jan Kara , Arnd Bergmann , Jan Kara , y2038@lists.linaro.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160617153916.444842-1-arnd@arndb.de> <20160619155347.GB2734@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160619155347.GB2734@quack2.suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 19, 2016 at 05:53:47PM +0200, Jan Kara wrote: > On Fri 17-06-16 17:39:00, Arnd Bergmann wrote: > > The jbd2 journal stores the commit time in 64-bit seconds and 32-bit > > nanoseconds, which avoids an overflow in 2038, but it gets the numbers > > from current_kernel_time(), which uses 'long' seconds on 32-bit > > architectures. > > > > This simply changes the code to call current_kernel_time64() so > > we use 64-bit seconds consistently. > > > > Signed-off-by: Arnd Bergmann > > The patch looks good. You can add: > > Reviewed-by: Jan Kara Applied, thanks. - Ted