From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbcF3X34 (ORCPT ); Thu, 30 Jun 2016 19:29:56 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:33667 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcF3X3z (ORCPT ); Thu, 30 Jun 2016 19:29:55 -0400 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Fri, 1 Jul 2016 08:28:12 +0900 From: Byungchul Park To: Peter Zijlstra Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, npiggin@suse.de, walken@google.com, ak@suse.de, tglx@inhelltoy.tec.linutronix.de Subject: Re: [RFC 05/12] lockdep: Implement crossrelease feature Message-ID: <20160630232812.GU2279@X58A-UD3R> References: <1466398527-1122-1-git-send-email-byungchul.park@lge.com> <1466398527-1122-6-git-send-email-byungchul.park@lge.com> <20160630130357.GE30154@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160630130357.GE30154@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 03:03:57PM +0200, Peter Zijlstra wrote: > On Mon, Jun 20, 2016 at 01:55:20PM +0900, Byungchul Park wrote: > > +struct cross_lock { > > + unsigned int gen_id; > > 4 byte hole > > > + struct list_head xlock_entry; > > + > > + /* > > + * Seperated hlock instance. This will be used when > > + * building a dependency chain for a crosslock, say, > > + * commit. > > + */ > > + struct held_lock hlock; > > + > > + int ref; /* reference count */ > > 4 byte hole > > > +}; > > A trivial re-arrangement would shrink this structure by 8 bytes. Ok. Thank you. > > After which its still at least 64 bytes. I will try to reduce the size as much as possible. However I think it's not serious problem beacuse this is just a debug feature. Thanks, Byungchul