From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] tests/xfs: test for post umount readahead completion panic
Date: Fri, 1 Jul 2016 11:40:02 +1000 [thread overview]
Message-ID: <20160701014002.GY27480@dastard> (raw)
In-Reply-To: <1467290974-13203-3-git-send-email-bfoster@redhat.com>
On Thu, Jun 30, 2016 at 08:49:34AM -0400, Brian Foster wrote:
> XFS has a bug where directory readahead completions can occur after
> unmount. This can lead to a crash or panic because metadata read
> verification attempts to access core XFS data structures (e.g., the log)
> after they have been freed and certain pointers have been reset.
>
> Add a test that triggers directory readahead, delays the readahead I/O
> and immediately unmounts the filesystem. This test is part of the
> dangerous group as it will cause kernels affected by the bug to crash.
.....
> +
> +# create a directory large enough for extent format
> +mkdir $SCRATCH_MNT/dir
> +for i in $(seq 0 999); do
> + touch $SCRATCH_MNT/dir/$i
> +done
minor quibble - what's an "extent format" directory? I think you
mean a directory inode whose data fork is in extent or btree format,
not inline. i.e. not a short-form directory, but rather a block,
leaf or node format directory.
Yeah, I'm being pedantic, but we should use the correct terminology
so when someone reads it in 5 years time....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-07-01 1:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:49 [PATCH 0/2] xfs: test for readahead use after free panic Brian Foster
2016-06-30 12:49 ` [PATCH 1/2] xfstests: support dm-delay to introduce I/O delays Brian Foster
2016-06-30 13:19 ` Eryu Guan
2016-06-30 13:44 ` Brian Foster
2016-06-30 13:47 ` Eryu Guan
2016-07-01 1:31 ` Dave Chinner
2016-06-30 12:49 ` [PATCH 2/2] tests/xfs: test for post umount readahead completion panic Brian Foster
2016-06-30 13:20 ` Eryu Guan
2016-07-01 1:40 ` Dave Chinner [this message]
2016-07-01 13:03 ` Brian Foster
2016-07-01 13:37 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701014002.GY27480@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.