From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e'
Date: Fri, 1 Jul 2016 12:10:42 +0200 [thread overview]
Message-ID: <20160701101042.GC3659@free.fr> (raw)
In-Reply-To: <1456435484-4723-2-git-send-email-universeII@gmx.de>
Andreas, All,
On 2016-02-25 22:24 +0100, Andreas Ehmanns spake thusly:
> set -e has been removed from init script since
> it causes the init script to terminate if an
> error occurs. This prevents the script to create
> an "FAIL" printout in case of an error.
And we're not doing it consistently either. I've looked at the startup
script for busybox (mdev, watchdog, telnet, logging) and none uses
'set -e'.
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/netsnmp/S59snmpd | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
> index cfda625..2762082 100755
> --- a/package/netsnmp/S59snmpd
> +++ b/package/netsnmp/S59snmpd
> @@ -1,4 +1,4 @@
> -#! /bin/sh -e
> +#! /bin/sh
> ### BEGIN INIT INFO
> # Provides: snmpd snmptrapd
> # Required-Start: $network $local_fs
> @@ -11,7 +11,6 @@
> #
> # Author: Jochen Friedrich <jochen@scram.de>
> #
> -set -e
>
> export PATH=/sbin:/usr/sbin:/bin:/usr/bin
>
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2016-07-01 10:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:24 [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Andreas Ehmanns
2016-02-25 21:24 ` [Buildroot] [PATCH 2/4] Package netsnmp: Removed 'set -e' Andreas Ehmanns
2016-07-01 10:10 ` Yann E. MORIN [this message]
2016-02-25 21:24 ` [Buildroot] [PATCH 3/4] Package netsnmp: Added missing reload of snmptrapd Andreas Ehmanns
2016-07-01 12:34 ` Yann E. MORIN
2016-02-25 21:24 ` [Buildroot] [PATCH 4/4] Package netsnmp: Added OK/FAIL output Andreas Ehmanns
2016-07-01 12:36 ` Yann E. MORIN
2016-07-01 13:04 ` Thomas Petazzoni
2016-07-06 16:47 ` Andreas Ehmanns
2016-07-01 10:08 ` [Buildroot] [PATCH 1/4] Package netsnmp: Created start(), stop(), reload() Yann E. MORIN
2016-07-01 13:01 ` Thomas Petazzoni
2016-07-02 10:25 ` Peter Korsgaard
2016-07-02 10:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701101042.GC3659@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.