Re: [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script

[Wei Liu <wei.liu2@citrix.com>]

> From 49714976c5fde3d08baa6f34295b3f7db6a81444 Mon Sep 17 00:00:00 2001
> From: Wei Liu <wei.liu2@citrix.com>
> Date: Fri, 15 Apr 2016 12:56:03 +0100
> Subject: [PATCH] libxl: debug output for args and env when invoking hotplug
>  script
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Ian, Ping?

> ---
> v2: write the loops differently.
> ---
>  tools/libxl/libxl_device.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index 4717027..b3213be 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -1167,6 +1167,24 @@ static void device_hotplug(libxl__egc *egc, libxl__ao_device *aodev)
>      }
>  
>      LOG(DEBUG, "calling hotplug script: %s %s", args[0], args[1]);
> +    LOG(DEBUG, "extra args:");
> +    {
> +        const char *arg;
> +        unsigned int x;
> +
> +        for (x = 2; (arg = args[x]); x++)
> +            LOG(DEBUG, "\t%s", arg);
> +    }
> +    LOG(DEBUG, "env:");
> +    {
> +        const char *k, *v;
> +        unsigned int x;
> +
> +        for (x = 0; (k = env[x]); x += 2) {
> +            v = env[x+1];
> +            LOG(DEBUG, "\t%s: %s", k, v);
> +        }
> +    }
>  
>      nullfd = open("/dev/null", O_RDONLY);
>      if (nullfd < 0) {
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel