From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rhzWX6FLKzDqnK for ; Sun, 3 Jul 2016 15:40:24 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u635dF3N112494 for ; Sun, 3 Jul 2016 01:40:22 -0400 Received: from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144]) by mx0a-001b2d01.pphosted.com with ESMTP id 23x7xd9avy-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sun, 03 Jul 2016 01:40:22 -0400 Received: from localhost by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 3 Jul 2016 15:40:19 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 3 Jul 2016 15:40:17 +1000 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: gwshan@linux.vnet.ibm.com X-IBM-RcptTo: openbmc@lists.ozlabs.org Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id E3F183578053 for ; Sun, 3 Jul 2016 15:40:16 +1000 (EST) Received: from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u635eGFO48955542 for ; Sun, 3 Jul 2016 15:40:16 +1000 Received: from d23av05.au.ibm.com (localhost [127.0.0.1]) by d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u635eGnU030216 for ; Sun, 3 Jul 2016 15:40:16 +1000 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14]) by d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u635eFkC030213; Sun, 3 Jul 2016 15:40:15 +1000 Received: from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) by ozlabs.au.ibm.com (Postfix) with ESMTP id 9A90AA00AB; Sun, 3 Jul 2016 15:40:15 +1000 (AEST) Received: from gwshan (shangw.ozlabs.ibm.com [10.61.2.199]) by bran.ozlabs.ibm.com (Postfix) with ESMTP id 884D0E3B49; Sun, 3 Jul 2016 15:40:15 +1000 (AEST) Received: by gwshan (Postfix, from userid 1000) id 81D21942D17; Sun, 3 Jul 2016 15:40:15 +1000 (AEST) Date: Sun, 3 Jul 2016 15:40:15 +1000 From: Gavin Shan To: Joel Stanley Cc: Gavin Shan , OpenBMC Maillist , Benjamin Herrenschmidt Subject: Re: [PATCH 10/10] net/farady: Mask PHY interrupt with NCSI mode Reply-To: Gavin Shan References: <1467282471-16560-1-git-send-email-gwshan@linux.vnet.ibm.com> <1467282471-16560-11-git-send-email-gwshan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16070305-0004-0000-0000-00000175D805 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16070305-0005-0000-0000-00000831E7E8 Message-Id: <20160703054015.GC9530@gwshan> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-07-03_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607030063 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2016 05:40:25 -0000 On Thu, Jun 30, 2016 at 11:36:07PM +0930, Joel Stanley wrote: >On Thu, Jun 30, 2016 at 7:57 PM, Gavin Shan wrote: >> if (pdev->dev.of_node && >> (of_get_property(pdev->dev.of_node, "use-nc-si", NULL) || >> of_get_property(pdev->dev.of_node, "use-ncsi", NULL))) { > >As before, lets pick single a property and stick with it. > The reason why I used two strings is the change is still fine on those BMCs where "ncsi-nc-si" is supported only. Joel, I personal prefer "use-ncsi". Lets adjust it later in device-tree. Thanks, Gavin