From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] vhost: reset queue state in destroy_device Date: Mon, 4 Jul 2016 10:24:41 +0800 Message-ID: <20160704022441.GS2831@yliu-dev.sh.intel.com> References: <1467390672-80701-1-git-send-email-rich.lane@bigswitch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Tetsuya Mukawa To: Rich Lane Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 42A922C2B for ; Mon, 4 Jul 2016 04:23:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1467390672-80701-1-git-send-email-rich.lane@bigswitch.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 01, 2016 at 09:31:12AM -0700, Rich Lane wrote: > Fixes a bug where rte_eth_vhost_get_queue_event would not return enabled queues > after a guest application restart. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > Signed-off-by: Rich Lane Acked-by: Yuanhan Liu Just some minor comments about the title (nothing big deal; it's just some DPDK preferences): - a bug fix patch need be titled as "fix ..." - it's better to hide specific function in the title. If you run "scripts/check-git-log.sh", you will find a warning. - the prefix should be "net/vhost". So, I'd like to reword the title a bit, to something like: "net/vhost: fix queue state not reset on destroy" If have no objection, I could fix it while apply. --yliu