From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 0/2] arm-cc*: fix PMU interrupt flags
Date: Mon, 4 Jul 2016 14:05:45 +0100 [thread overview]
Message-ID: <20160704130545.GA9048@leverpostej> (raw)
In-Reply-To: <20160704125740.GH1639@arm.com>
On Mon, Jul 04, 2016 at 01:57:40PM +0100, Will Deacon wrote:
> On Mon, Jul 04, 2016 at 12:25:30PM +0100, Mark Rutland wrote:
> > As discovered during review of the X-Gene SoC PMU [1], the arm-cc{i,n} drivers
> > don't ensure that IRQ balancers don't migrate interrupts.
> >
> > This is problematic for the perf core code, which requires mutual exclusion of
> > certain operations (e.g. event rotation, cross-calls, and irq handling) to be
> > provided by disabling IRQs, which only works if all operations occur on the
> > same CPU. This is also required for safe (lockless) manipulation of some data
> > structures.
> >
> > To avoid this problem, we must request interrupts with IRQF_NOBALANCING, as is
> > already the case for CPU PMU drivers which make use of interrupts.
> >
> > To ensure synchronisation between IRQ handlers and other manipulation of said
> > data structures or HW state, we must also ensure that the interrupt handlers
> > are not threaded, by requesting them with IRQF_NO_THREAD, as is already the
> > case for CPU PMU drivers.
>
> Thanks, looks good now:
>
> Reviewed-by: Will Deacon <will.deacon@arm.com>
Cheers!
I take it that as with the other recent CCI patch [1] you expect the
patches to go via arm-soc.
Arnd, Olof, are you happy to pick these patches?
Thanks,
Mark.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-July/440916.html
prev parent reply other threads:[~2016-07-04 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 11:25 [PATCHv2 0/2] arm-cc*: fix PMU interrupt flags Mark Rutland
2016-07-04 11:25 ` [PATCHv2 1/2] arm-ccn: " Mark Rutland
2016-07-04 11:25 ` [PATCHv2 2/2] arm-cci: " Mark Rutland
2016-07-04 12:57 ` [PATCHv2 0/2] arm-cc*: " Will Deacon
2016-07-04 13:05 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704130545.GA9048@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.