From: Theodore Ts'o <tytso@mit.edu>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: don't call ext4_should_journal_data() on the journal inode
Date: Mon, 4 Jul 2016 11:02:45 -0400 [thread overview]
Message-ID: <20160704150245.GD29557@thunk.org> (raw)
In-Reply-To: <5778B921.9060603@oracle.com>
Thanks, I've reworded the commit description as follows:
ext4: don't call ext4_should_journal_data() on the journal inode
If ext4_fill_super() fails early, it's possible for
ext4_evict_inode() to call ext4_should_journal_data() before
superblock options and flags are fully set up. In that case, the
iput() on the journal inode can end up causing a BUG().
Work around this problem by reordering the tests so we only call
ext4_should_journal_data() after we know it's not the journal inode.
Fixes: 2d859db3e4 ("ext4: fix data corruption in inodes with journalled data")
Fixes: 2b405bfa84 ("ext4: fix data=journal fast mount/umount hang")
Cc: Jan Kara <jack@suse.cz>
Cc: stable@vger.kernel.org
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
next prev parent reply other threads:[~2016-07-04 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 21:42 [PATCH] ext4: don't call ext4_should_journal_data() on the journal inode Vegard Nossum
2016-07-03 5:15 ` Theodore Ts'o
2016-07-03 7:05 ` Vegard Nossum
2016-07-04 15:02 ` Theodore Ts'o [this message]
2016-07-04 8:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704150245.GD29557@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.