From: Alison Schofield <amsfield22@gmail.com>
To: linux@roeck-us.net
Cc: Jean Delvare <jdelvare@suse.com>,
"open list:JC42.4 TEMPERATURE SENSOR DRIVER"
<linux-hwmon@vger.kernel.org>,
linux-kernel@vger.kernel.org, daniel.baluta@gmail.com
Subject: [RFC PATCH] hwmon: (jc42) Add I2C_CLASS_HWMON to detection class
Date: Mon, 4 Jul 2016 12:19:28 -0700 [thread overview]
Message-ID: <20160704191908.GA9056@d830.WORKGROUP> (raw)
In 2011, commit 774466add7c810fd7e4c8bcf41995b6799608880 changed
the detection class of these chips to I2C_CLASS_SPD based on this
premise: "makes more sense because these chips always live on
memory modules"
Today these chips have applications beyond memory modules.
Add I2C_CLASS_HWMON as an additional detection class to allow
detection by hwmon class i2c adapters.
Alternative is to replace the SPD w HWMON class, but that carries
risk for existing usage.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
drivers/hwmon/jc42.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 9887d32..1537ba0 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -538,7 +538,7 @@ static const struct i2c_device_id jc42_id[] = {
MODULE_DEVICE_TABLE(i2c, jc42_id);
static struct i2c_driver jc42_driver = {
- .class = I2C_CLASS_SPD,
+ .class = I2C_CLASS_SPD | I2C_CLASS_HWMON,
.driver = {
.name = "jc42",
.pm = JC42_DEV_PM_OPS,
--
2.1.4
next reply other threads:[~2016-07-04 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 19:19 Alison Schofield [this message]
2016-07-04 21:04 ` [RFC PATCH] hwmon: (jc42) Add I2C_CLASS_HWMON to detection class Guenter Roeck
2016-07-04 23:04 ` Alison Schofield
2016-07-04 23:27 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704191908.GA9056@d830.WORKGROUP \
--to=amsfield22@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.