All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix typo in link_path_walk()
Date: Mon, 4 Jul 2016 13:13:01 -0700	[thread overview]
Message-ID: <20160704201301.GA31238@vader> (raw)
In-Reply-To: <1467650933-20089-1-git-send-email-luisbg@osg.samsung.com>

On Mon, Jul 04, 2016 at 05:48:53PM +0100, Luis de Bethencourt wrote:
> Comment documenting the path parsing in link_path_walk() has a typo, fixing
> it.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> Noticed this typo while studying the code paths when sys_open is called.
> 
> Thanks,
> Luis
> 
>  fs/namei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 32f9fe9..ade7667 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2064,7 +2064,7 @@ static int link_path_walk(const char *name, struct nameidata *nd)
>  		if (!*name)
>  			goto OK;
>  		/*
> -		 * If it wasn't NUL, we know it was '/'. Skip that
> +		 * If it wasn't NULL, we know it was '/'. Skip that
>  		 * slash, and continue until no more slashes.
>  		 */
>  		do {
> -- 
> 2.6.4

NUL is the ASCII '\0' character. NULL is a pointer. So NUL is correct.

-- 
Omar

  reply	other threads:[~2016-07-04 20:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 16:48 [PATCH] vfs: fix typo in link_path_walk() Luis de Bethencourt
2016-07-04 20:13 ` Omar Sandoval [this message]
2016-07-04 20:50 ` Al Viro
2016-07-05 13:37   ` Luis de Bethencourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704201301.GA31238@vader \
    --to=osandov@osandov.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.